Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullReferenceException when the last playback device is disabled #433

Merged
merged 1 commit into from
May 7, 2020

Conversation

mooons
Copy link

@mooons mooons commented May 6, 2020

Fix issue #432

Checking if defaultDeviceId avoids NullReferenceException.
I also wanted to add an else clause to set the tray icon to default in this case, but didn't find an easy way. Any hints? @Belphemur

Please kindly review. :D

Copy link
Owner

@Belphemur Belphemur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One simple change to do for me to merge :)

Also about your question, I think we can live with the icon keeping the last playback device for now.

Copy link
Owner

@Belphemur Belphemur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little if inversion and good to go :)

@Belphemur Belphemur merged commit 77b3fe5 into Belphemur:dev May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants