Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatRoomSync-Split: Replacement functions only #79

Merged

Conversation

TessaTech
Copy link
Contributor

Even though this PR includes all the functions introduced in #76, it does not enable them for usage yet. For this purpose, seperate pull requests will be opened. This is to make testing the individual functions easier as requested by @Ben987.
The same has been done with the related Client PR #2253, which got split as described in #2272.

As this is the major part of the split of #76 in smaller PRs, i'll duplicate it's description here to make it easier to keep an overview over the total functionality

This is the related server PR to Client PR #2253

As in the client PR description mentioned, this Splits the ChatRoomSync function into multiple smaller calls which each transfers only the required data. It was not avoidable to add temporary code to check if a player uses the old game version (R66) or a new one. Depending on this, either the new ChatRoomSync alternative is called for beta players or the old ChatRoomSync for R66 players.

I'll remove this temporary code again once the beta is over and all players are using the new communication.

As also mentioned in the client PR, thorough testing is a necessity for big ones like this. And even though i'm sure there are no critical bugs, i want to encourage repeated tests during the review, just to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants