ChatRoomSync-Split: Enable ChatRoomSyncSwapPlayers #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TessaTech
force-pushed
the
feature.ChatRoomSync-Split.Enable-ChatRoomSyncSwapPlayers
branch
from
304755a
to
c152c69
Compare
|
@TessaTech , this one creates a conflict with the other merged pull requests. Can you resolve the conflict and test again? Thanks. |
TessaTech
force-pushed
the
feature.ChatRoomSync-Split.Enable-ChatRoomSyncSwapPlayers
branch
from
5689a5a
to
de7bbea
Compare
|
@Ben987 - Alright, got the time to rebase and test this. Works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #89
This PR enables the use of function
ChatRoomSyncSwapPlayersadded by PR #79 on which it depends. It is required by Client PR #2277.Edit:
ChatRoomSyncSwapPlayershas been replaced withChatRoomSyncReorderPlayers. This now relates on client PR 2279