use null coalescing operator instead of array_get

BenSampo · Oct 19, 2018 · 19e4551 · 19e4551
1 parent 09de9b3
commit 19e4551
Showing 1 changed file with 11 additions and 14 deletions.
diff --git a/src/EnumServiceProvider.php b/src/EnumServiceProvider.php
@@ -16,6 +16,7 @@ class EnumServiceProvider extends ServiceProvider
     public function boot()
     {
         $this->bootCommands();
+
         $this->bootValidators();
     }
 
@@ -41,27 +42,23 @@ private function bootCommands()
     private function bootValidators()
     {
         Validator::extend('enum_key', function($attribute, $value, $parameters, $validator) {
-            $enum = array_get($parameters, 0, null);
+            $enum = $parameters[0] ?? null;
+
             return (new EnumKey($enum))->passes($attribute, $value);
         });
 
         Validator::extend('enum_value', function($attribute, $value, $parameters, $validator) {
-            $enum = array_get($parameters, 0, null);
-            $strict = array_get($parameters, 1, null);
+            $enum = $parameters[0] ?? null;
+
+            $strict = $parameters[1] ?? null;
 
-            if ($strict) {
-                $strict = (boolean) json_decode(strtolower($strict));
-                return (new EnumValue($enum, $strict))->passes($attribute, $value);
+            if (! $strict) {
+                return (new EnumValue($enum))->passes($attribute, $value);
             }
 
-            return (new EnumValue($enum))->passes($attribute, $value);
-        });
-    }
+            $strict = !! json_decode(strtolower($strict));
 
-    /**
-     * Register any package services.
-     */
-    public function register()
-    {
+            return (new EnumValue($enum, $strict))->passes($attribute, $value);
+        });
     }
 }