Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are no menu shortcuts to create and restore Bails wallets #5

Closed
6 tasks done
BenWestgate opened this issue Jul 14, 2023 · 3 comments · Fixed by #161
Closed
6 tasks done

There are no menu shortcuts to create and restore Bails wallets #5

BenWestgate opened this issue Jul 14, 2023 · 3 comments · Fixed by #161
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers priority: high issues raised or encountered by 2 or more testers
Milestone

Comments

@BenWestgate
Copy link
Owner

BenWestgate commented Jul 14, 2023

Besides RE-running bails/b which will check for updates to Bitcoin core before starting bails-wallet there is no way to create or restore new Bails wallets.

A logical place for this shortcut is in bails-menu.

For bails-wallet to run standalone it needs:

  • A command to kill bitcoin{d,-qt} and wait for it to shutdown
  • A command to launch the bitcoin rpc server (use bitcoin-qt-wrapper -min -server -dbcache=-700 usual -maxmempool=5 -startupnotify=?)
  • wait for bitcoins -startupnotify to start before any line that needs RPC
  • After the descriptor import succeeds close the RPC server and wait for it to shutdown (make this a reused export function)
  • Environment variables used in bails-wallet must be set by an autostart
  • launch bitcoin-qt-wrapper with a -startupnotify= "wallet $name created success" dialog.

Then bails-menu would be able to call bails-wallet to create or restore an arbitrary amount of wallets without checking for bitcoin-core updates like running install-core to start bails-wallet would.

bails-wallet should probably not run automatically in install-bitcoin if the $DATA_DIR/wallets folder is not empty.

similar to how setup-persistence only runs when there is no persistence unlocked.

@BenWestgate BenWestgate added enhancement New feature or request good first issue Good for newcomers labels Jul 14, 2023
@BenWestgate BenWestgate self-assigned this Jul 14, 2023
@BenWestgate
Copy link
Owner Author

this depends on #4
bails-wallet needs to be able to run standalone securely before i can add it to the menus without awkwardly also checking for bitcoin core updates at the same time.

@BenWestgate BenWestgate added the priority: medium Issues raised by 1 tester label Jul 23, 2023
@BenWestgate BenWestgate added priority: high issues raised or encountered by 2 or more testers and removed priority: medium Issues raised by 1 tester labels Aug 31, 2023
@BenWestgate
Copy link
Owner Author

BenWestgate commented Aug 31, 2023

This is nearly in, just needs

  • Testing
  • Confirmation the wallet was created when Bitcoin-Qt starts
  • Logic to not run bails-wallet every software update.

BenWestgate pushed a commit that referenced this issue Mar 24, 2024
@BenWestgate BenWestgate added this to the L1 (BETA) milestone Mar 26, 2024
BenWestgate pushed a commit that referenced this issue May 16, 2024
@BenWestgate BenWestgate linked a pull request May 26, 2024 that will close this issue
@BenWestgate
Copy link
Owner Author

#161 bails-menu behaves as expected for loading and creating wallets from the menu. bails-wallet runs fully stand alone and bitcoin-qt runs with -server to handle its rpc calls.

Closed by #161.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority: high issues raised or encountered by 2 or more testers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant