Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Verification #161

Merged
merged 71 commits into from
May 26, 2024
Merged

Improve Verification #161

merged 71 commits into from
May 26, 2024

Conversation

BenWestgate
Copy link
Owner

@BenWestgate BenWestgate commented May 21, 2024

Closes #44
Closes #128

merge master into trust-individuals
@BenWestgate BenWestgate added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels May 21, 2024
@BenWestgate BenWestgate self-assigned this May 21, 2024
@BenWestgate BenWestgate linked an issue May 21, 2024 that may be closed by this pull request
New dialogs for Verification depending on whether the pre-Trusted keys passed verification or not.

Presents the same check_sigs loop as before if they want extra verification or do not have 3 good sigs.

Plan to make it an overall loop checking verify.py each time and passing a higher threshold if the user goes above and beyond the default 3.
We can get rid of most code verifying, downloading and have a much better code footprint outsourcing it to the python script in bitcoin-core.
needed the 3rd field not the 4th since we cd'd into bitcoin-core earlier.
…nt what gpg is doing, move slow gpg --refresh out of first runs, add interpreter for python script, move prune calc to just-in-time.
…ds, add Verify download signatures terminal title, remove reference to .tar.gz file, Extra>More Verication, Download>
…ed for 2 weeks. Don't install-core if b <arg>, just update Bails, environment var for bails VERSION, run bitcoin-qt in background so qt-wrapper can close
@BenWestgate
Copy link
Owner Author

@epiccurious: this is fully tested, passing CI and ready for your brief code review. I suggest skimming it so you're familiar with how much the code has changed in this branch so you can find everything later.

Copy link
Owner Author

@BenWestgate BenWestgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read all the changes and they look good to me.

@epiccurious
Copy link
Collaborator

ACK ba5c894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment