Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Verification #161

Merged
merged 71 commits into from
May 26, 2024
Merged

Improve Verification #161

merged 71 commits into from
May 26, 2024

Conversation

BenWestgate
Copy link
Owner

@BenWestgate BenWestgate commented May 21, 2024 •
edited

Closes #44
Closes #128

@BenWestgate
Merge pull request #160 from BenWestgate/master
daffae6 
merge master into trust-individuals
@BenWestgate BenWestgate added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels May 21, 2024
@BenWestgate BenWestgate self-assigned this May 21, 2024
@BenWestgate BenWestgate linked an issue May 21, 2024 that may be closed by this pull request
Trust Individuals #44
Closed
@BenWestgate
add 5 trusted-keys to the repository
2552221
@BenWestgate
use verify.py and trusted-keys crosschecked against guix.sigs
5386c3c 
New dialogs for Verification depending on whether the pre-Trusted keys passed verification or not.

Presents the same check_sigs loop as before if they want extra verification or do not have 3 good sigs.

Plan to make it an overall loop checking verify.py each time and passing a higher threshold if the user goes above and beyond the default 3.
@BenWestgate
Merge branch 'master' into 44-trust-individuals
5be3159
@BenWestgate
close unclosed if statement
cf4e4d7
@BenWestgate
quote VER variables to appease shellcheck
e090ea7
@BenWestgate
fix wrong variables in new fg commands
d25a90b
@BenWestgate
fix url to verification tool.
0af91ee
@BenWestgate
Add TODO comments about what to do with verify.py after PR merges
e1bfa6b 
We can get rid of most code verifying, downloading and have a much better code footprint outsourcing it to the python script in bitcoin-core.
@BenWestgate
fix wrong cut command to set $OLD_VER & $NEW_VER in install-core
0fba49f 
needed the 3rd field not the 4th since we cd'd into bitcoin-core earlier.
@BenWestgate
fix link_stat no such file in rsync bitcoin.conf command
77414bf
@BenWestgate
Fix $HOME directory not resetting properly. Change short-lived notifi…
40aae56 
…cation to an --info box.
@BenWestgate
Make verify.py part of a loop to do allow extra verification.
eceff81
@BenWestgate
fix sed not editing Bitcoin-Qt.conf for the Welcome prompt to reset t…
39551a6 
…o default datadir.
@BenWestgate
gui: fix weak passphrase detected dialog formatting.
fda2431
@BenWestgate
removed unneeded link_dotfiles command, quoted variables
1b5b4e6
@BenWestgate
quote variable
45cdf12
@BenWestgate
simplify check_sigs, no error message if bitcoin-core- missing, comme…
6e7292c 
…nt what gpg is doing, move slow gpg --refresh out of first runs, add interpreter for python script, move prune calc to just-in-time.
@BenWestgate
check for /state/installed and refresh-keys, delay waiting on downloa…
f13a667 
…ds, add Verify download signatures terminal title, remove reference to .tar.gz file, Extra>More Verication, Download>
@BenWestgate
re-launch persistent setup if dotfiles turn off, double quote some va…
1a6a54f 
…riables
@BenWestgate
add placeholders to keep these directories in vc
f70a1cf
@BenWestgate
make sure good_sig gets assigned before use
14b2864
@BenWestgate
source ~/.profile to fix bails-wallet not running
aa6712c
@BenWestgate
tar must happen before moving download
3ec951d
@BenWestgate BenWestgate linked an issue May 26, 2024 that may be closed by this pull request
Let's say what we are downloading in the terminal to increase trust #104
Closed
@BenWestgate BenWestgate mentioned this pull request May 26, 2024
Closed
@BenWestgate
warn if prune is off and space gets low, reactivate dbcache if unsync…
9aee73f 
…ed for 2 weeks. Don't install-core if b <arg>, just update Bails, environment var for bails VERSION, run bitcoin-qt in background so qt-wrapper can close
@BenWestgate
don't immediately display bails has installed/updated, auto exit bail…
7a8b8ac 
…s-wallet
@BenWestgate
Copy link
Owner Author

@epiccurious: this is fully tested, passing CI and ready for your brief code review. I suggest skimming it so you're familiar with how much the code has changed in this branch so you can find everything later.

BenWestgate
BenWestgate commented May 26, 2024
View reviewed changes
Copy link
Owner Author

@BenWestgate BenWestgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have read all the changes and they look good to me.

@BenWestgate BenWestgate added this to the L1 (BETA) milestone May 26, 2024
@BenWestgate BenWestgate linked an issue May 26, 2024 that may be closed by this pull request
Launch Bitcoin-Qt before importing Descriptors #128
Closed
@BenWestgate BenWestgate mentioned this pull request May 26, 2024
Closed
@BenWestgate BenWestgate linked an issue May 26, 2024 that may be closed by this pull request
tails-screen-locker just sort of appears on the screen without any explanation during descriptor importing #57
Closed
@epiccurious
Copy link
Collaborator

ACK ba5c894

@BenWestgate BenWestgate mentioned this pull request May 26, 2024
Closed
This was linked to issues May 26, 2024
search guix.sigs/<current release> rather than builder-keys for verification #21
Closed
Hard code a shortlist of trusted signers so "Skip" still does some verification #17
Closed
@BenWestgate BenWestgate mentioned this pull request May 26, 2024
Closed
@BenWestgate BenWestgate linked an issue May 26, 2024 that may be closed by this pull request
There are no menu shortcuts to create and restore Bails wallets #5
Closed
6 tasks
@BenWestgate BenWestgate mentioned this pull request May 26, 2024
Closed
6 tasks
@BenWestgate BenWestgate disabled auto-merge May 26, 2024 19:57
@BenWestgate BenWestgate merged commit 6064cf4 into master May 26, 2024
4 checks passed
@BenWestgate BenWestgate deleted the 44-trust-individuals branch May 26, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epiccurious epiccurious epiccurious approved these changes

Assignees

@BenWestgate BenWestgate

Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
L1 (BETA)
2 participants
@BenWestgate @epiccurious