Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Verification #161

Merged
merged 71 commits into from
May 26, 2024
Merged

Improve Verification #161

merged 71 commits into from
May 26, 2024

Commits on May 21, 2024

  1. Merge pull request #160 from BenWestgate/master 

    merge master into trust-individuals
    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    daffae6 View commit details
    Browse the repository at this point in the history

  2. add 5 trusted-keys to the repository

    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2552221 View commit details
    Browse the repository at this point in the history

  3. use verify.py and trusted-keys crosschecked against guix.sigs 

    New dialogs for Verification depending on whether the pre-Trusted keys passed verification or not.

Presents the same check_sigs loop as before if they want extra verification or do not have 3 good sigs.

Plan to make it an overall loop checking verify.py each time and passing a higher threshold if the user goes above and beyond the default 3.
    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5386c3c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into 44-trust-individuals

    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    5be3159 View commit details
    Browse the repository at this point in the history

  5. close unclosed if statement

    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    cf4e4d7 View commit details
    Browse the repository at this point in the history

  6. quote VER variables to appease shellcheck

    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e090ea7 View commit details
    Browse the repository at this point in the history

  7. fix wrong variables in new fg commands

    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d25a90b View commit details
    Browse the repository at this point in the history

  8. fix url to verification tool.

    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0af91ee View commit details
    Browse the repository at this point in the history

  9. Add TODO comments about what to do with verify.py after PR merges 

    We can get rid of most code verifying, downloading and have a much better code footprint outsourcing it to the python script in bitcoin-core.
    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e1bfa6b View commit details
    Browse the repository at this point in the history

  10. fix wrong cut command to set $OLD_VER & $NEW_VER in install-core 

    needed the 3rd field not the 4th since we cd'd into bitcoin-core earlier.
    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0fba49f View commit details
    Browse the repository at this point in the history

  11. fix link_stat no such file in rsync bitcoin.conf command

    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    77414bf View commit details
    Browse the repository at this point in the history

  12. Fix $HOME directory not resetting properly. Change short-lived notifi… 

    …cation to an --info box.
    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    40aae56 View commit details
    Browse the repository at this point in the history

  13. Make verify.py part of a loop to do allow extra verification.

    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    eceff81 View commit details
    Browse the repository at this point in the history

  14. fix sed not editing Bitcoin-Qt.conf for the Welcome prompt to reset t… 

    …o default datadir.
    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    39551a6 View commit details
    Browse the repository at this point in the history

  15. gui: fix weak passphrase detected dialog formatting.

    @BenWestgate
    BenWestgate committed May 21, 2024
    Configuration menu
    Copy the full SHA
    fda2431 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. removed unneeded link_dotfiles command, quoted variables

    @BenWestgate
    BenWestgate committed May 23, 2024
    Configuration menu
    Copy the full SHA
    1b5b4e6 View commit details
    Browse the repository at this point in the history

  2. quote variable

    @BenWestgate
    BenWestgate committed May 23, 2024
    Configuration menu
    Copy the full SHA
    45cdf12 View commit details
    Browse the repository at this point in the history

  3. simplify check_sigs, no error message if bitcoin-core- missing, comme… 

    …nt what gpg is doing, move slow gpg --refresh out of first runs, add interpreter for python script, move prune calc to just-in-time.
    @BenWestgate
    BenWestgate committed May 23, 2024
    Configuration menu
    Copy the full SHA
    6e7292c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. check for /state/installed and refresh-keys, delay waiting on downloa… 

    …ds, add Verify download signatures terminal title, remove reference to .tar.gz file, Extra>More Verication, Download>
    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f13a667 View commit details
    Browse the repository at this point in the history

  2. re-launch persistent setup if dotfiles turn off, double quote some va… 

    …riables
    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1a6a54f View commit details
    Browse the repository at this point in the history

  3. add placeholders to keep these directories in vc

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f70a1cf View commit details
    Browse the repository at this point in the history

  4. make sure good_sig gets assigned before use

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    14b2864 View commit details
    Browse the repository at this point in the history

  5. source ~/.profile to fix bails-wallet not running

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    aa6712c View commit details
    Browse the repository at this point in the history

  6. tar must happen before moving download

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3ec951d View commit details
    Browse the repository at this point in the history

  7. delete everything in download folder before retrying.

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f312067 View commit details
    Browse the repository at this point in the history

  8. opt out of retrying download to 'X'

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    05012e3 View commit details
    Browse the repository at this point in the history

  9. add opt out by pressing 'X' to the other two failure messages.

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4f0ef0e View commit details
    Browse the repository at this point in the history

  10. add file back to verify.py to avoid MISSING printing

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    83b9b6e View commit details
    Browse the repository at this point in the history

  11. attempt to detect existing installation better

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5397d05 View commit details
    Browse the repository at this point in the history

  12. remove background process for gpg_refresh, just wait in main process … 

    …on it.
    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    22ebe64 View commit details
    Browse the repository at this point in the history

  13. signature download must complete before trying to get version & chang… 

    …e directory! Cleanup get keys command
    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6b4d4e8 View commit details
    Browse the repository at this point in the history

  14. simplify download commands 

    there is no need for parenthesis anymore because we don't need to cd before the download. Lets clone guix.sigs every install because it's our way of checking if the signatures we try to import are still valid.
    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1ee37b6 View commit details
    Browse the repository at this point in the history

  15. just use good_sig to check sigs. use verify.py to check at the end. I… 

    …mprove retry if integrity fails.
    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c8b4f75 View commit details
    Browse the repository at this point in the history

  16. fix unary operator expected

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3b8e56c View commit details
    Browse the repository at this point in the history

  17. fix condition to launch bails-wallet, notification looked better

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    14188e9 View commit details
    Browse the repository at this point in the history

  18. stop printing secrets to terminal 

    Remove clear notifications since it no longer works
    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9aecc7b View commit details
    Browse the repository at this point in the history

  19. export stop-btc as a new command

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b7e8bc8 View commit details
    Browse the repository at this point in the history

  20. comment out unreachable lines

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e76af21 View commit details
    Browse the repository at this point in the history

  21. remove datadir entry from BitcoinQt.conf

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5b44b49 View commit details
    Browse the repository at this point in the history

  22. fix dialog width, don't start qt automatically, remove funded check

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4c963ed View commit details
    Browse the repository at this point in the history

  23. fix prune calc to not warn on welcome

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4499c59 View commit details
    Browse the repository at this point in the history

  24. Update install-core

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    18bd4af View commit details
    Browse the repository at this point in the history

  25. stop bitcoin-wallet from starting and stopping core, use bitcoin-qt

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2df354d View commit details
    Browse the repository at this point in the history

  26. fix json format

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    7cdf031 View commit details
    Browse the repository at this point in the history

  27. fix getting stuck in loop if the user doesn't open bitcoin core.

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    04b1433 View commit details
    Browse the repository at this point in the history

  28. delay link_dotfiles, tmpfs install from b, simplify wget, don't copy … 

    …bails_dir if it's unset, launch qt minimized
    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    53d6259 View commit details
    Browse the repository at this point in the history

  29. don't ask for passphrase when we're already in spaced-repetition

    @BenWestgate
    BenWestgate committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d346d8f View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Remove all dbus-send commands that no longer work

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    d664a39 View commit details
    Browse the repository at this point in the history

  2. correct datadir path typo for wallet search

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    82db508 View commit details
    Browse the repository at this point in the history

  3. install BAILS to dotfiles from b script, rm unused variable, relocate… 

    … bitcoin.conf to dotfiles/.bitcoin to ensure correct datadir is used, use tpscli to check tps status, update synlinks accordingly
    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    391c87e View commit details
    Browse the repository at this point in the history

  4. fix erroneous '"' in script

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    11c904f View commit details
    Browse the repository at this point in the history

  5. add the tmpfs log to bitcoin.conf

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    1eb97f8 View commit details
    Browse the repository at this point in the history

  6. mkdir -p needed now that rsync doesn't copy to DATA_DIR anymore

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    bb8bfc4 View commit details
    Browse the repository at this point in the history

  7. Clean up several dialogs from bails-wallet for Tails 6.0

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    a356040 View commit details
    Browse the repository at this point in the history

  8. add placeholded README.md for ~.bitcoin

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    dc8e92e View commit details
    Browse the repository at this point in the history

  9. use correct tpscli command "is_unlocked"

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    05a927c View commit details
    Browse the repository at this point in the history

  10. double quote variables

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    3c9bd45 View commit details
    Browse the repository at this point in the history

  11. correct is_unlocked to is-unlocked

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    672795a View commit details
    Browse the repository at this point in the history

  12. rewrite builder-keys with only those who signed the most recent relea… 

    …se for faster verification
    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    beec719 View commit details
    Browse the repository at this point in the history

  13. attempt to prevent logout after restoring a wallet.

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    b38cc0a View commit details
    Browse the repository at this point in the history

  14. removed notifications from chainstate-preload, only prompt ab lock pa… 

    …ssword if not set, made bitcoin-qt-wrapper handle uris
    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    18f9303 View commit details
    Browse the repository at this point in the history

  15. ensure persistent features are activated, each start

    @BenWestgate
    BenWestgate committed May 25, 2024
    Configuration menu
    Copy the full SHA
    2680226 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. bump version, remove settings coming soon, they're complete

    @BenWestgate
    BenWestgate committed May 26, 2024
    Configuration menu
    Copy the full SHA
    dd6b095 View commit details
    Browse the repository at this point in the history

  2. fix settings dialog formatting

    @BenWestgate
    BenWestgate committed May 26, 2024
    Configuration menu
    Copy the full SHA
    f0a1f28 View commit details
    Browse the repository at this point in the history

  3. fix setting prune and dbcache at launch

    @BenWestgate
    BenWestgate committed May 26, 2024
    Configuration menu
    Copy the full SHA
    ae7ddd7 View commit details
    Browse the repository at this point in the history

  4. warn if prune is off and space gets low, reactivate dbcache if unsync… 

    …ed for 2 weeks. Don't install-core if b <arg>, just update Bails, environment var for bails VERSION, run bitcoin-qt in background so qt-wrapper can close
    @BenWestgate
    BenWestgate committed May 26, 2024
    Configuration menu
    Copy the full SHA
    9aee73f View commit details
    Browse the repository at this point in the history

  5. don't immediately display bails has installed/updated, auto exit bail… 

    …s-wallet
    @BenWestgate
    BenWestgate committed May 26, 2024
    Configuration menu
    Copy the full SHA
    7a8b8ac View commit details
    Browse the repository at this point in the history

  6. do not continue execution if dotfiles was off

    @BenWestgate
    BenWestgate committed May 26, 2024
    Configuration menu
    Copy the full SHA
    4f9fd5a View commit details
    Browse the repository at this point in the history

  7. move update all keys title to gpg --refresh-keys

    @BenWestgate
    BenWestgate committed May 26, 2024
    Configuration menu
    Copy the full SHA
    5d10774 View commit details
    Browse the repository at this point in the history

  8. correct comment about symlinks

    @BenWestgate
    BenWestgate committed May 26, 2024
    Configuration menu
    Copy the full SHA
    222725f View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into 44-trust-individuals

    @BenWestgate
    BenWestgate committed May 26, 2024
    Configuration menu
    Copy the full SHA
    ba5c894 View commit details
    Browse the repository at this point in the history