-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning duty #4
Conversation
The hidden files you've removed aren't useless as such, they wouldn't exist if they were useless. However they do store OS X preferences etc. so removing them is probably a good idea. I would like to keep the autogen.sh output files as outlined in the issue comments. I would also like to keep the udev install script and instructions as most Linux don't know what udev rules are, so they certainly don't know how to install them. Although you're correct to provide a separate rules file for situations where the user would like to install them manually. The repository is intentionally setup in a way that makes Heimdall compilation and installation fairly straight-forward for non-developers. The README outlines, exactly, all the steps necessary to compile and install Heimdall. As you've noticed this does come at the cost customisability. I won't directly pull from your fork as I only want to include a subset of the changes, and I still need to decide on exactly which subset. |
ok, thanks |
InitialiseProtocol: reset device before handshake and upload artifacts
Hi,
I thought that instead of complaining in your issue tracker, I will just propose some changes to you :)
There is 3 commit, the first one is just removing all files generated by autogen.sh + adding an arguments into Makefile.am as suggested by autoreconf.
The 1 and 3rd removes also some useless hidden files
and the 2nd one is reorganising a bit the way to provide the udev rules.
Of course I will not be hurt if you don't accept them :)
Thank you for your work anyway!