allow a decimal format for an integer #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msaglietto
reviewed
Nov 8, 2016
| @@ -658,7 +661,7 @@ | |||
|
|
|||
| w = d.split('.')[0]; | |||
|
|
|||
| if (d.split('.')[1].length) { | |||
| if (d.split('.').length > 1 && d.split('.')[1].length) { | |||
There was a problem hiding this comment.
mm in here you are doing the split like 4 times .. maybe its better to save the result of the split and then use it
There was a problem hiding this comment.
sounds like a good idea 😄
don't error when an integer is formatted as a decimal with a wildcard.
ex:
`numbro(-40).format('#.*');` will now return `'-40'`
fixes BenjaminVanRyseghem#199, see for more context
mguida22
force-pushed
the
decimal-format
branch
from
b1b3669
to
086c7bc
Compare
|
THanks @mguida22 I think it looks ok now .. what do you think @BenjaminVanRyseghem could we merge this .. I could use it =P ... |
|
thanks 👍 |
|
Thanks for the feedback on this! |
|
in numbro 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #199, when using a decimal format with a wildcard, on an integer, numbro gives an error
This addresses the issue by checking for a decimal before attempting to format it. The same line from above will now return
'-40'