-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holiday File Issue #11
Comments
Hi, Saurabh, Thanks for raising this issue. I see its a problem on my own local repo as well. A better solution: If there is a holiday as per holiday.json, we re-download the file to verify it. |
I have made the changes and code is working correctly. Changes are in If you have the latest changes from the repo all you need to do is run Downloading Files
Starting Data Sync
EOD sync complete
Delivery Data updated
Delivery sync complete
Index sync complete.
Makings adjustments for splits and bonus
Cleaning up files
2 files deleted
28 Jun 2023: Done
----------------------------------------------------
All Up To Date. Check again after 7pm for today's EOD data Thanks again Saurabh, the issues you raise have been very helpful to improve the repo. If you have any feature requests i would love to hear from you. |
Thanks Benny. Works fine. |
Hello,
There seems to be another issue related to holiday.json.
{
"tradingDate": "28-Jun-2023",
"weekDay": "Wednesday",
"description": "Bakri Id",
"Sr_no": 10
},
This is the holiday.json which is incorrect as the holiday was changed yesterday by NSE.
I have fixed it by removing the file and it downloaded the same but try to see if you can get the latest file everyday.
Thanks
Saurabh
The text was updated successfully, but these errors were encountered: