Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions does not work correctly #120

Closed
Azriael2 opened this issue May 7, 2019 · 5 comments
Closed

Permissions does not work correctly #120

Azriael2 opened this issue May 7, 2019 · 5 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Azriael2
Copy link

Azriael2 commented May 7, 2019

I'm getting problem with permissions for bskyblock.mod and bskyblock.admin. Even with set permissions, players can't use /bsb delete or can be expeled from islands with permission bskyblock.mod.bypassexpel. I'm using MoxPerms which works same way as PermissionsEx. Adding bskyblock.admin.* works fine.

Permissions which doesn't work correctly:

  • bskyblock.admin.deleteisland
  • bskyblock.admin.noban
  • bskyblock.mod.bypasscooldowns
  • bskyblock.mod.bypassexpel
  • bskyblock.mod.info
  • bskyblock.mod.resethome
  • bskyblock.mod.resetname
  • bskyblock.admin.reserve
  • bskyblock.mod.team

Permissions which works fine:

  • bskyblock.mod.tp / bskyblock.admin.tp

  • Database being used: MySQL
  • BentoBox version: v1.4.0
  • Addons installed?

[16:54:26 INFO]: Aktualnie: SPIGOT 1.13.2.
[16:54:26 INFO]: Wersja Bentobox: [name]
[16:54:26 INFO]: Załadowane światy gry
[16:54:26 INFO]: BSkyBlock_world
[16:54:26 INFO]: Załadowane dodatki
[16:54:26 INFO]: Biomes 0.4.5
[16:54:26 INFO]: BSkyBlock 1.4.1
[16:54:26 INFO]: Level 1.4.0
[16:54:26 INFO]: WelcomeWarps 1.4.0

[16:54:49 INFO]: Plugins (53): CleanroomGenerator, ColoredSigns, MoxBlood, PlaceholderAPI, PlugMan, VoxelSniper, PetBlocks, WorldEdit, Skript, PacketListenerApi, MoxCore, skDragon, GlowAPI, SkQuery, WorldBorder, MoxTokensDatabase, ProtocolLib, MVdWPlaceholderAPI, GlobalMarket, FeatherBoard, SQLibrary, LiteJoin, skUtilities, Vault, PlayerParticles, ProtocolSupport, CommandButtons, MoxChatTitles, HolographicDisplays, TuSKe, WorldGuard, MobStacker, HolographicScoreboard, MoxPerms, Essentials, ChatInjector, MoxPlayerParticles, HeadDatabase, Citizens, BentoBox, EssentialsChat, TAB, ProtocolSupportStuff, MoxPremiumShop, CitizensCMD, skRayFall, EssentialsProtect, EssentialsSpawn, MorkazSk, Multiverse-Core, BossShopPro, ItemShops, CraftBook


I also can't find commands for these permissions (so commands protect and lock):

  • bskyblock.mod.bypasslock
  • bskyblock.mod.bypassprotect
  • bskyblock.mod.lock

And can't find permission for /bsbadmin getrank.

@Poslovitch
Copy link
Member

Most of the permissions are actually stale ones, outdated and or not even in use.

Running through all of them to see which ones exist and actually work is going to be a tedious yet necessary process.

@Azriael2
Copy link
Author

Azriael2 commented May 7, 2019

Is there any easier way? I don't want to give every permission to them nor none of them, becuase finding them will be too hard.

Also, any way to give them permissions to PLACE_BLOCKS without getting rank on player islands?

@tastybento tastybento added bug Something isn't working good first issue Good for newcomers under investigation labels May 7, 2019
@tastybento tastybento self-assigned this May 7, 2019
@Poslovitch
Copy link
Member

I'll try to work on writing down proper documentation for this.

tastybento added a commit to BentoBoxWorld/BentoBox that referenced this issue May 7, 2019
tastybento added a commit that referenced this issue May 7, 2019
tastybento added a commit to BentoBoxWorld/AcidIsland that referenced this issue May 7, 2019
@tastybento
Copy link
Member

These ones do not have commands and being removed for now. They could become commands in the future:

  • bskyblock.admin.deleteisland
  • bskyblock.mod.resethome
  • bskyblock.mod.resetname (also bskyblock.mod.setname)
  • bskyblock.admin.reserve
  • bskyblock.admin.purge

The following are bugs and will be fixed:

  • bskyblock.admin.noban
  • bskyblock.mod.bypasscooldowns
  • bskyblock.mod.bypassexpel
  • bskyblock.mod.info
  • bskyblock.mod.team (was set to bskyblock.admin.team)

More checking is required. We used the permissions list as a TODO list in the past, so maybe not all the permissions are supported yet.

@tastybento
Copy link
Member

I think this is done now from a code perspective. If you agree @Poslovitch please close.

tastybento added a commit that referenced this issue Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants