Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Negative Y Levels #473

Closed
Angeschossen opened this issue Apr 26, 2022 · 1 comment · Fixed by BentoBoxWorld/BentoBox#1971
Closed

[API] Negative Y Levels #473

Angeschossen opened this issue Apr 26, 2022 · 1 comment · Fixed by BentoBoxWorld/BentoBox#1971

Comments

@Angeschossen
Copy link

Expected behavior

island.getProtectionBoundingBox().contains(x, -y, z) should return true if the island contains this coordinate.

Observed/Actual behavior

The islands minimum y level is always 0.

Steps/models to reproduce

Call island.getProtectionBoundingBox().contains(x, -y, z) with a negative y value.

BentoBox version

Running PAPER 1.18.1.
BentoBox version: 1.20.1
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, The End
Loaded Addons:
Biomes 1.13.0 (ENABLED)
BSkyBlock 1.15.1 (ENABLED)
Challenges 0.8.4 (ENABLED)
ControlPanel 1.13.0 (ENABLED)
DimensionalTrees 1.6.0 (ENABLED)
Level 2.7.0 (ENABLED)
Limits 1.17.0 (ENABLED)
Warps 1.10.2 (ENABLED)

Plugin list

No response

Other

This has been reported to me. I'm able to reproduce it. I could not find an option in the config to change the minimum y level.

BONNe added a commit to BentoBoxWorld/BentoBox that referenced this issue Apr 26, 2022
#1966 fixed a bounding box size for the whole island, while the protection bounding box was still wrong.

Fixes BentoBoxWorld/BSkyBlock#473
BONNe added a commit to BentoBoxWorld/BentoBox that referenced this issue Apr 26, 2022
#1966 fixed a bounding box size for the whole island, while the protection bounding box was still wrong.

Fixes BentoBoxWorld/BSkyBlock#473
BONNe added a commit to BentoBoxWorld/BentoBox that referenced this issue Apr 26, 2022
#1966 fixed a bounding box size for the whole island, while the protection bounding box was still wrong.

Fixes BentoBoxWorld/BSkyBlock#473
@Angeschossen
Copy link
Author

Angeschossen commented Jul 24, 2022

Apparently the last block before the island border are affected as well. So the radius is technically seen: radius = radius-1 blocks. In the latest dev build.

Someone reported this to me. I don't see any reason why this should be caused by the plug-in that hooks into your API. I won't be able to test it before August.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants