Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chorus is not handled by the TREES_GROWING_OUTSIDE_RANGE flag #1079

Closed
Poslovitch opened this issue Dec 23, 2019 · 2 comments
Closed

Chorus is not handled by the TREES_GROWING_OUTSIDE_RANGE flag #1079

Poslovitch opened this issue Dec 23, 2019 · 2 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone

Comments

@Poslovitch
Copy link
Member

Description

Describe the bug

Chorus can grow outside the island's boundaries, even though trees are not supposed to.

Steps to reproduce the behavior

  1. Set the TREES_GROWING_OUTSIDE_RANGE flag to 'disabled'.
  2. Place a chorus flower on a block of end stone inside the island's protected space, but at the very limit of the protection range.
  3. Let it grow.

Expected behavior

Chorus should not be able to grow outside the island's boundaries.

Screenshots and videos (Optional)

image

Environment

BentoBox Version (Mandatory)
Running SPIGOT 1.14.4.
BentoBox version: 1.10.0-SNAPSHOT-LOCAL
Database: JSON
Loaded Game Worlds:
bskyblock_world (BSkyBlock): Overworld, Nether, End
Loaded Addons:
Biomes 1.6.0.1 (ENABLED)
BSkyBlock 1.9.0 (ENABLED)
Challenges 0.8.0 (ENABLED)
ControlPanel 1.7.0 (ENABLED)
DimensionalTrees 1.6.0 (ENABLED)
Level 1.9.0 (ENABLED)
Warps 1.9.0 (ENABLED)

Plugins (Optional)

Plugins (5): LuckPerms, Vault, PlaceholderAPI, BentoBox, Essentials

Additional context (Optional)

None.

@Poslovitch Poslovitch added Type: Bug Status: Pending Waiting for a developer to start working on this issue. labels Dec 23, 2019
@Poslovitch
Copy link
Member Author

This looks oddly satisfying ahah.
image

@Poslovitch Poslovitch self-assigned this Dec 27, 2019
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Pending Waiting for a developer to start working on this issue. labels Dec 27, 2019
@Poslovitch Poslovitch added this to the 1.10.0 milestone Dec 27, 2019
@Poslovitch
Copy link
Member Author

This also allowed me to provide some documentation/examples on SpigotMC about this: https://www.spigotmc.org/threads/chorus-plant-flower-growth-event.173896/#post-3639916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant