Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a message to all players on the island or that are members of it when PvP is toggled on/off #1081

Closed
Poslovitch opened this issue Dec 23, 2019 · 0 comments
Closed

Send a message to all players on the island or that are members of it when PvP is toggled on/off #1081

Poslovitch opened this issue Dec 23, 2019 · 0 comments
Assignees
@Poslovitch
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone
1.11.1

Comments

@Poslovitch
Copy link
Member

Description

Is your feature request related to a problem?

Inspired by #1080.

Unlike ASkyBlock, if PvP is toggled on, there is no means for the players on the island to know this happened.

Describe the solution you'd like us to implement.

Send a message to all the island's visitors, as well as to the island's members, to tell them PvP was enabled/disabled and in which dimension it occurred.

Describe alternatives you've considered.

None.

Additional context

None.
@Poslovitch Poslovitch added Type: Enhancement Improvement or modification which is usually a new feature. Status: Pending Waiting for a developer to start working on this issue. labels Dec 23, 2019
@Poslovitch Poslovitch added Status: In progress Working on the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Feb 2, 2020
@Poslovitch Poslovitch self-assigned this Feb 2, 2020
@Poslovitch Poslovitch added this to the 1.11.1 milestone Feb 2, 2020
Poslovitch added a commit that referenced this issue Feb 13, 2020
@Poslovitch
Added a message sent to all players on an island when PvP is toggled
9abf657 
Implements #1081

Also removed the "protection.flags.PVP_OVERWORLD.active" message as it seemingly wasn't used.
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Poslovitch Poslovitch

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.11.1
Development

No branches or pull requests
1 participant
@Poslovitch