End portal teleportation

[werken23]

Description

Describe the bug

Jumping in an end portal sometimes teleports you to a wrong location in the end resulting in falling into the void.

Steps to reproduce the behavior

1. build an end portal in a random location on your overworld/nether island.
2. jump in the portal.
3. repeat a few times because it doesnt always happen.

Expected behavior

making sure the teleport location is safe before teleporting.

Screenshots and videos (Optional)

Environment

BentoBox Version (Mandatory)

26.03 13:22:33 [Server] INFO Running PAPER 1.15.2.
26.03 13:22:33 [Server] INFO BentoBox version: 1.12.0
26.03 13:22:33 [Server] INFO Database: JSON
26.03 13:22:33 [Server] INFO Loaded Game Worlds:
26.03 13:22:33 [Server] INFO skyblock_world (SkyBlock): Overworld, Nether, [end_color]End
26.03 13:22:33 [Server] INFO Loaded Addons:
26.03 13:22:33 [Server] INFO AutoIslandFly 1.0.0 (ENABLED)
26.03 13:22:33 [Server] INFO Biomes 1.6.0.1 (ENABLED)
26.03 13:22:33 [Server] INFO BSkyBlock 1.12.0 (ENABLED)
26.03 13:22:33 [Server] INFO Challenges 0.8.0 (ENABLED)
26.03 13:22:33 [Server] INFO Chat 1.0.4 (ENABLED)
26.03 13:22:33 [Server] INFO ControlPanel 1.7.0 (ENABLED)
26.03 13:22:33 [Server] INFO DimensionalTrees 1.6.0 (ENABLED)
26.03 13:22:33 [Server] INFO EpicHooks 1.0.0 (ENABLED)
26.03 13:22:33 [Server] INFO ExtraMobs 1.11.0.2 (ENABLED)
26.03 13:22:33 [Server] INFO IslandFly 1.7.2-SNAPSHOT-b102 (ENABLED)
26.03 13:22:33 [Server] INFO Level 1.9.3 (ENABLED)
26.03 13:22:33 [Server] INFO Likes 1.7.0 (ENABLED)
26.03 13:22:33 [Server] INFO Limits 1.9.2 (ENABLED)
26.03 13:22:33 [Server] INFO MagicCobblestoneGenerator 1.9.0-SNAPSHOT-LOCAL (ENABLED)

Plugins (Optional)

_______

Additional context (Optional)

[NotMyFault]

I'm running into the same issue. Sometimes you are teleported on your end island and sometimes you are falling into the void. I'll provide a video of the behavior below. Like you can see it just happens from time to time.
https://youtu.be/4ickZurPiGw
Here is a link to my end island blueprint: https://www.mediafire.com/file/xevdtuhvw7tyu9e/new-end1.blu/file
The spawn sign is in the middle of the island.
I'm using BentoBox v1.13.0 build 1696 and BSkyBlock v1.11.2 build 594
+++
This is doesn't belong to here, but I also noted this color mismatch here, like you can see in the code block of the author of the ticket with [end_color].

[tastybento]

The [nether_color] and [end-color] tags appear to be old and have been removed from the English locale. I removed them from the source, but they will need manually removing from your locale files. If you haven't done any customization on locales, the easiest way to clean them is to just delete the locale folder and restart the server.

For the teleporting, it's hard for me to test, but it looks like a tick issue. I'll commit a new version and if you can confirm it works, that'd be great. There was actually legacy code in the safe spot teleport class that was trying to preserve the velocity of the player.

[Blatower21]

Still happening, it happens when the player jump into the portal, if you walk into it you don't appear in the air.

[tastybento]

Yeah, I've jumped in multiple times and I can't make it happen. I wish I could replicate. I'll try another approach and see if it helps.

[tastybento]

BentoBox-1.13.0-SNAPSHOT-LOCAL.jar.zip

Could you try this one? It has some debug in it too that should show on the console the player's velocity when they start the teleport and immediately after. Please share it if the player still flies off into the void.

[NotMyFault]

BentoBox-1.13.0-SNAPSHOT-LOCAL.jar.zip

Could you try this one? It has some debug in it too that should show on the console the player's velocity when they start the teleport and immediately after. Please share it if the player still flies off into the void.

I used the version linked and the following debug lines were the results when a player has been teleported into the void:
[BentoBox] DEBUG: Setting player's velocity to 0 before teleport
[BentoBox] DEBUG: Insta teleport Player's velocity = 0.0,0.0,0.0
[BentoBox] DEBUG: Setting player's velocity to 0 after teleport

[tastybento]

And does it still occur? Did those results track the situation when the player jumps through and gets thrown into the void? The debit says the player has zero velocity so they should be stationary...

[NotMyFault]

Yeah, but it happens still.

[tastybento]

I'm going to have to add more debug. I think that another process is kicking in to do this, or the server itself is doing it. Thanks for the report. We'll work it out!