Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.16.3 Nether Portal Problem #1527

Closed
myavuzokumus opened this issue Sep 21, 2020 · 18 comments
Closed

1.16.3 Nether Portal Problem #1527

myavuzokumus opened this issue Sep 21, 2020 · 18 comments
Assignees
@tastybento
Labels
1.16 Related to 1.16+ Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.

Comments

@myavuzokumus
Copy link
Contributor

myavuzokumus commented Sep 21, 2020 •
edited
Loading

Describe the bug

I can't teleport nether island on normal island. If i enable nether on server.properties, i can go nether island.

Output of /bbox version (Mandatory)

image

Why this problem all times happen when switch to new Minecraft version :D
@BONNe
Copy link
Member

BONNe commented Sep 21, 2020

Because it is done by Mojang server engine.
Your only hope is to ask old behavior to be implemented by spigot or paper teams. BentoBox kinda is not a correct place where do it.

@BONNe
Copy link
Member

BONNe commented Sep 22, 2020

Well, you could ask for a feature request, so BentoBox handles teleportations by itself, and do not relay on Minecraft Teleportation at all.

So when player enters in Nether Portal block, it teleports player to world even if nether is disabled in server.properties.

However, I do not know how costly it would be... (for performance)

@myavuzokumus
Copy link
Contributor Author

myavuzokumus commented Oct 3, 2020 •
edited
Loading

Ok, if there is no problem with performance, I would appreciate if it can be done.
Because md_5 has not been looking at my request for 11 days. The players are mad at me for not being able to go to the nether world.
https://hub.spigotmc.org/jira/browse/SPIGOT-6148

By the way, the same problem exists in the portal to the end world.

@myavuzokumus myavuzokumus reopened this Oct 3, 2020
@myavuzokumus
Copy link
Contributor Author

@tastybento @Poslovitch When can you look this issue?

@tastybento tastybento added 1.16 Related to 1.16+ Status: Under investigation Investigating the interest and the feasability of the issue. Type: Enhancement Improvement or modification which is usually a new feature. labels Oct 5, 2020
@tastybento
Copy link
Member

I can look at it. But what is the problem with the work around of setting server.properties nether = true?

@myavuzokumus
Copy link
Contributor Author

myavuzokumus commented Oct 5, 2020 •
edited
Loading

If i set to true, nether portal can teleport to nether island. If false, it cant.
Same problem on end portal. "allow-end in bukkit.yml"

@tastybento
Copy link
Member

Indeed. So, is there a reason why you cannot just set those to true? Or to put it another way, why are you setting them to false?

@myavuzokumus
Copy link
Contributor Author

If i set to true, extra new normal nether world being created. The also same is problem in the end world.

@tastybento
Copy link
Member

I implemented a teleportation mechanism, but there is another problem: If the nether is not activated in the server, then the nether world never ticks and there are no monsters. I don't think there is a way for me to fix this. You have to enable the nether on the server and then maybe protect the normal nether world if you don't want people going there.

@myavuzokumus
Copy link
Contributor Author

I can teleport to nether island with command and a lot of mob in island 👍
image

@myavuzokumus
Copy link
Contributor Author

Can you make the same fix for the end world and release it as a dev version?

@tastybento
Copy link
Member

Yes, I’ll do that.

@myavuzokumus
Copy link
Contributor Author

I hope you finish it soon.

@tastybento
Copy link
Member

It's a bit tricky, but I'm making progress.

@tastybento tastybento self-assigned this Oct 7, 2020
@tastybento tastybento added Status: In progress Working on the issue. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Oct 7, 2020
tastybento added a commit that referenced this issue Oct 7, 2020
@tastybento
Enables nether and end teleporting even if they are disabled by server
2efd96f 
#1527
@tastybento tastybento mentioned this issue Oct 7, 2020
Merged
@tastybento
Copy link
Member

BentoBox-1.15.1-SNAPSHOT-LOCAL.jar.zip
Try this version and let me know how well it works for you.

@myavuzokumus
Copy link
Contributor Author

It works very well. Thanks <3

@tastybento
Copy link
Member

Cool. I'm going to do some more testing. Also I might switch to using this approach all the time.

tastybento added a commit that referenced this issue Oct 11, 2020
@tastybento
Enables nether and end teleporting even if they are disabled by server (
fad1fc8 
#1539)

* Enables nether and end teleporting even if they are disabled by server

#1527

* Fix PortalTeleportationListener tests

* Revert Travis.yml
@Poslovitch
Copy link
Member

Any news on this @tastybento? Can we close this issue?

@tastybento tastybento removed the Status: In progress Working on the issue. label Nov 25, 2020
@tastybento tastybento added the Status: Done This issue has been completed or answered. This pull request has been merged. label Nov 25, 2020
@myavuzokumus myavuzokumus mentioned this issue Mar 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
1.16 Related to 1.16+ Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@BONNe @tastybento @Poslovitch @myavuzokumus