-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vanished players are exposed by ban and expel commands #1573
Comments
Hmm, tricky. Expel can be fixed, Ban cannot. The problem here is the definition of "admin". If the admin is Op, then there is no issue. However, if the admin is ad admin because of perms, then there is an issue because perms can only be checked when the player is online. Ban Command The situation now:
Admin with the
The only way to not expose a vanished perm-based admin would be to allow them to be banned, which of course, defeats the purpose of the Expel Command The situation now:
Admin with the
This can be fixed so that if Op or Admin are vanished then the player will see the "player is offline" error. |
@tastybento, thanks for the detailed response. |
Sorry for the late response (busy IRL) - Ops cannot be banned. I think removing the admin.noban perm makes sense because there is a bypass ban permission. |
It might be a good idea to remove the block on banning Ops too because they can rely on the bypass perm anyway. |
In my opinion, removing the block on banning Ops would be a good idea. Currently, in my case, it looks like it's impossible to disable the block on banning admins without a lot of permission changes - I'm using LuckPerms which overrides the vanilla OP system. |
Description
Describe the bug
By using "is ban" and "is expel" commands, it's possible to check whether a player is online and vanished on the server.
Steps to reproduce the behavior
Observed:
Observed:
Expected behavior
For both commands, the command output message should be changed to be consistent no matter if the admin is online or not.
Environment
Output of
/bbox version
(Mandatory)Additional context (Optional)
I thought that this issue was reported here before, but I can't find any bug report for these two commands. The only relevant issue I found is #972, but it doesn't contain these two specific commands - they might have been not noticed when fixing that issue or this bug appeared later on.
The text was updated successfully, but these errors were encountered: