Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very strange situation with teams/placeholders not working #1753

Closed
NoobcoreNetwork opened this issue May 4, 2021 · 2 comments
Closed

Very strange situation with teams/placeholders not working #1753

NoobcoreNetwork opened this issue May 4, 2021 · 2 comments
Assignees
Labels
Status: Cannot replicate Could not replicate the issue on a fresh install. More details are needed. Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug

Comments

@NoobcoreNetwork
Copy link

NoobcoreNetwork commented May 4, 2021

So. I'm having issues with the placeholder %bskyblock_visited_island_members_max%

No matter whos island im on it always shows MY members max. And not the actual owners members max.

Doing papi parse me %bskyblock_visited_island_members_max% no matter whos island i'm on will show me my max teamsize permission value.

This is me on a persons island who has a max teamsize of 3 permission
5

Basically the %bskyblock_visited_island_members_max% and %bskyblock_island_members_max% Return the same value regardless of whos island youre on, it shows your own value based on the teamsize permission you have.

I'm unsure why this is happening, But i have triple checked my configs,

This was discovered by finding a huge bug, So, the standard size team you're suppose to be allowed is 2. You and 1 other friend, I had the permission to have 3, I teleported to a team of 2's island and it let them add another team member when i was visiting it basically took my teamsize permission and let them use it while i was temporarily on the island. I left and now the scoreboard says Members 3/2 for them.

Steps to reproduce the behavior

Give yourself bskyblock.team.maxsize.14
Visit someones island who has a different max size value.

Parse the permission %bskyblock_visited_island_members_max%
and it will return your value of 14. not the island youre on.

Expected behavior

The permission should show the visited islands count not your own and it definitely shouldn't apply your permission to the island your visiting,
I tested the other permissions like island size to see if they mess up too, but the only one that seems to affect is the max team size.

Screenshots and videos (Optional)

Environment

Output of /bbox version (Mandatory)

I cannot provide a text output i think chatcontrol is blocking the output going to console or logs sorry but i have a picture
send

_______

Plugins (Optional)

_______

Additional context (Optional)

Updated every other plugin on my server to see if it helps and It didn't also tried on an older build of bentobox and bskyblock with no luck either.

Created brand new install on a new server with the same issue

@tastybento tastybento self-assigned this May 7, 2021
@tastybento tastybento added Status: Under investigation Investigating the interest and the feasability of the issue. Status: In progress Working on the issue. Type: Bug labels May 7, 2021
tastybento added a commit that referenced this issue May 7, 2021
The placeholders were not using the correct API call and so were
reporting based on the player's permission and not the actual island's
maxteam size.

#1753
@tastybento
Copy link
Member

I have fixed the placeholder issue. I cannot replicate the problem you report whereby an island can inherit a visitor's permissions. I also cannot see in the code how that would happen right now. Can you try the latest Snapshot from ci.bentobox.world and confirm that the placeholder is fixed? Then can you try and replicate that other issue you had?

@tastybento tastybento added Status: Cannot replicate Could not replicate the issue on a fresh install. More details are needed. Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. Status: Under investigation Investigating the interest and the feasability of the issue. labels May 9, 2021
@NoobcoreNetwork
Copy link
Author

I think it was some kind of weird glitch as i cannot replicate it either currently but the placeholder issue is now fixed, thanks alot bento youre a legend :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Cannot replicate Could not replicate the issue on a fresh install. More details are needed. Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants