Pvp enabled message showing to coop/trusted players even when they are not present on the island.

[bipedd]

Expected behavior

The PvP enabled messages should only show when you teleport/enter the island that has PVP enabled.

Observed/Actual behavior

The message shows for trusted and cooped players even when they are not present on the island that PVP was enabled on. So if I am trusted on player 1's island but am at my own island, I still get that PVP-enabled message which can lead to confusion on if it's been enabled on your own island. Basically, the plugin isn't checking if cooped/trusted players are present on the island to then send the message to, it just sends it to them without checking.

Steps/models to reproduce

Need two accounts.

1. Have account 1 make an island, then trust you.
2. On account 2, go to your own island.
3. On account 1 enable PVP.
4. Check the chat of account 2.

BentoBox version

01.12 06:08:09 [Server] INFO Running PAPER 1.17.1.
01.12 06:08:09 [Server] INFO BentoBox version: 1.17.3
01.12 06:08:09 [Server] INFO Database: JSON
01.12 06:08:09 [Server] INFO Loaded Game Worlds:
01.12 06:08:09 [Server] INFO bskyblock_world (BSkyBlock): Overworld, Nether, The End
01.12 06:08:09 [Server] INFO Loaded Addons:
01.12 06:08:09 [Server] INFO Bank 1.3.2 (ENABLED)
01.12 06:08:09 [Server] INFO Biomes 1.14.0 (ENABLED)
01.12 06:08:09 [Server] INFO Border 3.2.0 (DISABLED)
01.12 06:08:09 [Server] INFO BSkyBlock 1.15.1 (ENABLED)
01.12 06:08:09 [Server] INFO Challenges 0.8.4 (ENABLED)
01.12 06:08:09 [Server] INFO Chat 1.1.4 (ENABLED)
01.12 06:08:09 [Server] INFO IslandFly 1.8.1 (ENABLED)
01.12 06:08:09 [Server] INFO Level 2.7.0 (ENABLED)
01.12 06:08:09 [Server] INFO MagicCobblestoneGenerator 2.3.0 (ENABLED)
01.12 06:08:09 [Server] INFO TwerkingForTrees 1.4.3 (ENABLED)
01.12 06:08:09 [Server] INFO Warps 1.10.2 (ENABLED)

Plugin list

No response

Other

No response

[BONNe]

Can confirm:
https://github.com/BentoBoxWorld/BentoBox/blob/develop/src/main/java/world/bentobox/bentobox/listeners/flags/settings/PVPListener.java#L229

I think this code could be adjusted to:

	@EventHandler(priority = EventPriority.NORMAL)
	public void onPVPFlagToggle(final FlagSettingChangeEvent e) {
		Flag flag = e.getEditedFlag();
		// Only care about PVP Flags
		if (Flags.PVP_OVERWORLD.equals(flag) || Flags.PVP_NETHER.equals(flag) || Flags.PVP_END.equals(flag)) {
			String message = "protection.flags." + flag.getID() + "." + (e.isSetTo() ? "enabled" : "disabled");
			// Send the message to players on the island
			e.getIsland().getPlayersOnIsland().forEach(player -> User.getInstance(player).sendMessage(message));
		}
	}

It will notify all players on the island about a flag change.

[bipedd]

Can confirm:

https://github.com/BentoBoxWorld/BentoBox/blob/develop/src/main/java/world/bentobox/bentobox/listeners/flags/settings/PVPListener.java#L229

I think this code could be adjusted to:

	@EventHandler(priority = EventPriority.NORMAL)

	public void onPVPFlagToggle(final FlagSettingChangeEvent e) {

		Flag flag = e.getEditedFlag();

		// Only care about PVP Flags

		if (Flags.PVP_OVERWORLD.equals(flag) || Flags.PVP_NETHER.equals(flag) || Flags.PVP_END.equals(flag)) {

			String message = "protection.flags." + flag.getID() + "." + (e.isSetTo() ? "enabled" : "disabled");

			// Send the message to players on the island

			e.getIsland().getPlayersOnIsland().forEach(player -> User.getInstance(player).sendMessage(message));

		}

	}

It will notify all players on the island about a flag change.

Would that be added in a future update?

[bipedd]

Any update?

[tastybento]

Done. It's in the latest BentoBox snapshot for 1.18 and also the one for 1.17.1

[bipedd]

Done. It's in the latest BentoBox snapshot for 1.18 and also the one for 1.17.1

Thank you!

[bipedd]

I'd like to re-open this issue due to me finding another issue that has the same subject:

Expected behavior
The PvP enabled messages should only show when you teleport/enter the island that has PVP enabled.

Observed/Actual behavior
When "block glitching" into a block while mining it, it spams the PVP-enabled message.

Steps/models to reproduce
Mine a block fast while also running into it.

BentoBox version
[03:08:59 INFO]: Running PAPER 1.18.1.
[03:08:59 INFO]: BentoBox version: 1.20.0
[03:08:59 INFO]: Database: JSON
[03:08:59 INFO]: Loaded Game Worlds:
[03:08:59 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[03:08:59 INFO]: Loaded Addons:
[03:08:59 INFO]: Bank 1.4.0 (ENABLED)
[03:08:59 INFO]: Biomes 1.14.0 (ENABLED)
[03:08:59 INFO]: BSkyBlock 1.15.2 (ENABLED)
[03:08:59 INFO]: Challenges 0.8.4 (ENABLED)
[03:08:59 INFO]: Chat 1.1.4 (ENABLED)
[03:08:59 INFO]: IslandFly 1.8.1 (ENABLED)
[03:08:59 INFO]: Level 2.9.0 (ENABLED)
[03:08:59 INFO]: MagicCobblestoneGenerator 2.3.0 (ENABLED)
[03:08:59 INFO]: TwerkingForTrees 1.4.3 (ENABLED)
[03:08:59 INFO]: Warps 1.11.1 (ENABLED)

Videos/images
https://user-images.githubusercontent.com/77213949/158532277-04c639d3-27ba-4185-be22-3c8a0484f8a7.mp4

Badlion.Client.2022.03.15.-.23.44.41.03.DVR_Trim.mp4

[bipedd]

It seems to be happening every time I teleport back to the island. The issue is it shouldn't show even if I'm teleporting to a different spot on the island since I'm already on the island. In this video I was doing /top.
https://user-images.githubusercontent.com/77213949/158539373-bf824ebb-4943-48c6-ae30-3b5e660cfbbf.mp4

[BONNe]

Yes, I notice that too... I will create a patch shortly :)