Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protection from editing to hanging signs #2274

Closed
SirvydasS opened this issue Jan 16, 2024 · 1 comment
Closed

Add protection from editing to hanging signs #2274

SirvydasS opened this issue Jan 16, 2024 · 1 comment
Assignees
@tastybento
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug

Comments

@SirvydasS
Copy link

Expected behavior

On 1.20.4, hanging signs can be edited by anyone.

Observed/Actual behavior

On 1.20.4, hanging signs can be edited by anyone.

Steps/models to reproduce

Use 1.20.4 and go to another player's island as a non-Op. Click on a hanging sign and it can be edited, both sides.

BentoBox version

2.0.0-SNAPSHOT-b2531

Plugin list

No response

Other

No response
@tastybento tastybento self-assigned this Jan 19, 2024
@tastybento tastybento added Type: Bug Status: Under investigation Investigating the interest and the feasability of the issue. Status: In progress Working on the issue. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Jan 19, 2024
tastybento added a commit that referenced this issue Jan 20, 2024
@tastybento
Fixes #2274 hanging signs protection
212a646
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Jan 20, 2024
@tastybento
Copy link
Member

Fixed. The protection is in the sign editing flag/setting in user settings. Thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tastybento @SirvydasS