Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPE /island team world.bentobox.bentobox.database.objects.Island.getCenter() #2310

Closed
IAISI opened this issue Mar 1, 2024 · 1 comment
Closed
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug

Comments

@IAISI
Copy link

IAISI commented Mar 1, 2024

Expected behavior

Not sure, from what I can see in logs NPE showed up after player issued /island team

Observed/Actual behavior

com.destroystokyo.paper.exception.ServerEventException: Could not pass event InventoryClickEvent to BentoBox v2.1.0
	at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:72)
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126)
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615)
	at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:3107)
	at net.minecraft.network.protocol.game.PacketPlayInWindowClick.a(PacketPlayInWindowClick.java:58)
	at net.minecraft.network.protocol.game.PacketPlayInWindowClick.a(PacketPlayInWindowClick.java:23)
	at net.minecraft.network.protocol.PlayerConnectionUtils.a(PlayerConnectionUtils.java:54)
	at net.minecraft.server.TickTask.run(TickTask.java:18)
	at net.minecraft.util.thread.IAsyncTaskHandler.d(IAsyncTaskHandler.java:153)
	at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(IAsyncTaskHandlerReentrant.java:24)
	at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1464)
	at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:195)
	at net.minecraft.util.thread.IAsyncTaskHandler.x(IAsyncTaskHandler.java:126)
	at net.minecraft.server.MinecraftServer.bl(MinecraftServer.java:1441)
	at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1364)
	at net.minecraft.util.thread.IAsyncTaskHandler.bu(IAsyncTaskHandler.java:114)
	at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:1556)
	at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1224)
	at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:321)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: java.lang.NullPointerException: Cannot invoke "world.bentobox.bentobox.database.objects.Island.getCenter()" because "this.island" is null
	at BentoBox.jar//world.bentobox.bentobox.api.commands.island.team.IslandTeamCommand.lambda$createInvitedButton$7(IslandTeamCommand.java:306)
	at BentoBox.jar//world.bentobox.bentobox.listeners.PanelListenerManager.lambda$onInventoryClick$0(PanelListenerManager.java:56)
	at java.base/java.util.Optional.ifPresent(Optional.java:178)
	at BentoBox.jar//world.bentobox.bentobox.listeners.PanelListenerManager.onInventoryClick(PanelListenerManager.java:54)
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor967.execute(Unknown Source)
	at org.bukkit.plugin.EventExecutor$2.execute(EventExecutor.java:77)
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:77)
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70)
	at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54)
	at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:126)
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:615)
	at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClick(ServerGamePacketListenerImpl.java:3107)
	at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:58)
	at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:23)
	at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:54)
	at net.minecraft.server.TickTask.run(TickTask.java:18)
	at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153)
	at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24)
	at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1464)
	at net.minecraft.server.MinecraftServer.wrapRunnable(MinecraftServer.java:195)
	at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126)
	at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1441)
	at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1364)
	at net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:114)
	at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1556)
	at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1224)
	... 2 more

Steps/models to reproduce

Not sure.

BentoBox version

[22:26:48 INFO]: BentoBox version: 2.1.0
[22:26:48 INFO]: Database: JSON
[22:26:48 INFO]: Loaded Game Worlds:
[22:26:48 INFO]: bskyblock_world (BSkyBlock): Overworld, Nether, The End
[22:26:48 INFO]: Loaded Addons:
[22:26:48 INFO]: Bank 1.7.1-SNAPSHOT-b87 (ENABLED)
[22:26:48 INFO]: Biomes 2.2.0-SNAPSHOT-b258 (ENABLED)
[22:26:48 INFO]: Border 4.2.2-SNAPSHOT-b196 (ENABLED)
[22:26:48 INFO]: BSkyBlock 1.17.1 (ENABLED)
[22:26:48 INFO]: CauldronWitchery 2.1.0-SNAPSHOT-#62 (ENABLED)
[22:26:48 INFO]: Challenges 1.3.0-SNAPSHOT-b542 (ENABLED)
[22:26:48 INFO]: CheckMeOut 1.2.0-SNAPSHOT-b95 (ENABLED)
[22:26:48 INFO]: ControlPanel 1.13.1 (ENABLED)
[22:26:48 INFO]: DimensionalTrees 1.7.0 (ENABLED)
[22:26:48 INFO]: ExtraMobs 1.13 (ENABLED)
[22:26:48 INFO]: IslandFly 1.12.0 (ENABLED)
[22:26:48 INFO]: Level 2.12.1-SNAPSHOT-b560 (ENABLED)
[22:26:48 INFO]: Likes 2.4.0-SNAPSHOT-b102 (ENABLED)
[22:26:48 INFO]: MagicCobblestoneGenerator 2.5.2-SNAPSHOT-b272 (ENABLED)
[22:26:48 INFO]: TwerkingForTrees 1.5.0 (ENABLED)
[22:26:48 INFO]: Visit 1.7.0-SNAPSHOT (ENABLED)
[22:26:48 INFO]: Warps 1.15.0-SNAPSHOT-b362 (ENABLED)

Plugin list

No response

Other

No response

@tastybento tastybento self-assigned this Mar 2, 2024
@tastybento tastybento added Type: Bug Status: Under investigation Investigating the interest and the feasability of the issue. labels Mar 2, 2024
tastybento added a commit that referenced this issue Mar 2, 2024
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Mar 2, 2024
@tastybento
Copy link
Member

Thanks! I will release 2.1.1 with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants