Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area Height negative layer #2334

Closed
DeltaX86 opened this issue Mar 22, 2024 · 2 comments
Closed

Area Height negative layer #2334

DeltaX86 opened this issue Mar 22, 2024 · 2 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.

Comments

@DeltaX86
Copy link

Expected behavior

Hello,

I've come to you after discovering a problem with bentobox with addon boxed. With the new minecraft upgrades we have world departure in -64 so in the config.yml area-height: -62. However this is not the case for the Nether, so when copying blueprint in the nether it will try to set the nether blueprint to -64. However, this is not possible as the nether starts at 0. It will therefore delete any part that is too large. I wanted to know if there was a solution or if there will be a next update with the idea of a nether-area-height?

Thank you and have a nice day.

Observed/Actual behavior

At the moment, we can put a negative layer in the height layer. However, this creates bugs in the nether because it cannot also have a negative layer (and you create a similar nether world).

Steps/models to reproduce

Create a box with blueprint at size of minecraft 1.20.4 world (with negative layer start aera-height)

BentoBox version

[19:18:32 INFO]: Paper 1.20.4.
[19:18:32 INFO]: Version de BentoBox : 2.2.1-SNAPSHOT-b2585
[19:18:32 INFO]: Base de données : JSON
[19:18:32 INFO]: Mondes de jeu chargés :
[19:18:32 INFO]: boxed_world (Boxed) : Overworld, Nether
[19:18:32 INFO]: Addons chargés :
[19:18:32 INFO]: Bank 1.7.1-SNAPSHOT-b87 (ENABLED)
[19:18:32 INFO]: BentoBoxFAWEHandler 1.1.0 (ENABLED)
[19:18:32 INFO]: Border 4.2.2-SNAPSHOT-b197 (ENABLED)
[19:18:32 INFO]: Boxed 2.4.0 (ENABLED)
[19:18:32 INFO]: Challenges 1.3.0 (ENABLED)
[19:18:32 INFO]: Chat 1.2.0 (ENABLED)
[19:18:32 INFO]: ControlPanel 1.13.1 (ENABLED)
[19:18:32 INFO]: Level 2.12.1-SNAPSHOT-b560 (ENABLED)
[19:18:32 INFO]: Likes 2.4.0-SNAPSHOT-b102 (ENABLED)
[19:18:32 INFO]: Limits 1.20.1 (ENABLED)
[19:18:32 INFO]: RoseStackerHook 1.0.0 (ENABLED)
[19:18:32 INFO]: Visit 1.7.0-SNAPSHOT (ENABLED)

Plugin list

No response

Other

No response

@tastybento
Copy link
Member

I hadn't envisaged a blueprint for the Nether, but yes, this should be addressed. I'll look into it.

@tastybento tastybento self-assigned this Mar 22, 2024
@tastybento tastybento transferred this issue from BentoBoxWorld/Boxed Mar 29, 2024
@tastybento
Copy link
Member

tastybento commented Mar 29, 2024

This is helped with this change. The Nether blueprint will now not paste below the world minimum, so if you set the area height to < 0 then it will paste at 0. i.e., the bedrock block will be at y = 0. This should enable you to make nether blueprints that don't get cut off.
BTW, this is a change in BentoBox because this is where the pasting is done.

@tastybento tastybento added the Status: Done This issue has been completed or answered. This pull request has been merged. label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.
Projects
None yet
Development

No branches or pull requests

2 participants