Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing island range larger than config resets range on logout #484

Closed
lukeeexd opened this issue Jan 22, 2019 · 1 comment
Closed

changing island range larger than config resets range on logout #484

lukeeexd opened this issue Jan 22, 2019 · 1 comment
Assignees
@tastybento
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone
1.4.0

Comments

@lukeeexd
Copy link

lukeeexd commented Jan 22, 2019 •
edited
Loading

Description
Doing /bsbadmin range set [name] [value] will reset the island size on relog if you set the island size larger than the config range.

Steps to reproduce the behavior:
https://streamable.com/qoutg

In this the config protection range is 50, setting the range to 100 increases but once you logout it goes back to 50.

Expected behavior
It would be nice for this not to happen as we can create shops for island size upgrades by executing commands to extend an island size on purchase (deluxe menus for example)

Server Information:

[Please complete the following information:]

  • Database being used (YAML, JSON, MySQL, MongoDB): YAML

  • OS: Ubuntu 18.04.1 LTS

  • Java Version: Java 8

  • BentoBox version: 1.1

  • Addons installed? BSkyBlock 1.0, Challenges 0.3.0 and Level 0.2.0

  • Other plugins? https://i.imgur.com/kQ4TIYs.png

Additional context
Add any other context about the problem here.
@Tobydj
Copy link

Tobydj commented Jan 23, 2019

You also need to give the player the permission bsyblock.island.range.100

@tastybento tastybento added the Status: Under investigation Investigating the interest and the feasability of the issue. label Jan 23, 2019
@Poslovitch Poslovitch added Type: Bug Status: Pending Waiting for a developer to start working on this issue. Priority: High and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Feb 20, 2019
@tastybento tastybento self-assigned this Mar 4, 2019
@tastybento tastybento added this to the 1.4.0 milestone Mar 4, 2019
@tastybento tastybento removed the Status: Pending Waiting for a developer to start working on this issue. label Mar 4, 2019
tastybento added a commit that referenced this issue Mar 4, 2019
@tastybento
Fixes range resetting if player does not have a range permission.
15f9792 
If a player's island range is set using the range set admin command, the
range was being reset when the player logged in if they had no range
permission.

#484
@Poslovitch Poslovitch added the Status: Done This issue has been completed or answered. This pull request has been merged. label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
1.4.0
Development

No branches or pull requests
4 participants
@tastybento @Poslovitch @lukeeexd @Tobydj