-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BentoBox not enabled on start-up #503
Comments
We need the full log from startup because the reason for why BentoBox is not starting up is likely above what you pasted. |
https://blackdog.straight8.com/drops/log-for-BentoBox.txt Note that BentoBox is enabled approximately 6 seconds after the "not enabled" messages. Despite those messages, BentoBox, BSkyBlock, Challenges, and Level are enabled and appear to work correctly. Please let me know when you have the log file, so I can delete it (I try to keep the dropbox clean). |
log.txt.zip Question: Do you have BentoBox specified anywhere in say bukkit.yml? I suspect not, but I thought I'd ask. What I see is that the worlds are loading before BentoBox is enabled and this error is coming from the server code itself (WorldCreator.java to be specific). I don't know why the server knows that the world generator is BentoBox because BentoBox itself should be the one to load this world. I suspect that it may be a conflict with WorldEdit. I'm going to try and see I can replicate the issue. |
No mentions of BentoBox (or any variant lower- or upper-case) in any of the server-level YAML files. I agree with your assessment. Potentially relevant plugins versions:
|
I tried both of those and they're okay. I've been trying to see if Residence causes the worlds to load. Unfortunately, it's a premium plugin and the source code doesn't build due to dependencies so I can't test it. As it is FREE software under the GPL it is absolutely fine for you to place a zipped copy in this ticket so I can test it. I'll delete it afterward out of respect for the author's desire to charge, but I'd appreciate the help. License: https://github.com/Zrips/Residence/blob/master/LICENSE |
Fortunately: I am using version 4.8.4.4 BTW, I support a lot of developers. You could be one of them, if you posted a donation link. |
Thanks. It doesn't seem to be Residences. |
I do not detect any negative consequences. Only the messages. It is vaguely worrisome that loadbefore is not honored. However:
so you might be able to resolve it by adding
|
Let me make you a build with that and you can try and see if that helps at all. |
I can edit plugin.yml myself. :) |
That change did not work. Same messages as before. I guess that isn't a complete surprise, given:
Is it possible that [softdepend] and [loadbefore] do not like hyphens? |
bentobox-1.2.1-SNAPSHOT.jar.zip |
Wait, you just tried it yourself. That build won't help. So, can you try a copy of your server on a test server and see if deleting plugins reveals anything? |
Why not? I unzipped the jar, edited plugin.yml to add a softdepend for Multiverse-Core, re-zipped the jar. In my experience, that works fine. But I tried your build also: same result (as expected).
Which plugins would you like me to delete? I don't understand how removing other plugins would change the enable order of BentoBox wrt Multiverse-Core. |
Okay, good news - I just had the issue happen and I only have Multiverse and BentoBox on my server, so it does appear like for some reason Multiverse was loading before BentoBox. This was with the build that tried the soft-depend. I recompiled the build to go back to loadbefore and it now loads in the correct order. Here's that version attached. Is it random? I don't know. Can you see if this works for you? For donations, um could you send an Amazon gift card code to donate@bentobox.world? |
I was wrong. My reading (and some experimentation) suggest that load order is not directly relevant, despite the name of the directive (loadbefore). Enable order is the issue. Looking at CityWorld (another generator), I see in plugin.yml
just like BentoBox 1.2.0 (Multiverse-Core has neither loadbefore nor softdepend directives). As you can see, both BentoBox and CityWorld are loaded prior to Multiverse-Core. But CityWorld is enabled prior to Multiverse-Core, and BentoBox is not.
|
Just for fun, I inserted
into Multiverse-Core. This did not have the expected effect: the results were the same. It causes me to muse:
|
This line is suspicious:
I found this in the Residence code: Clearly it enables the Multiverse plugin if it isn't already enabled. So, what's happening is that Residence is forcing Multiverse to enable when it does. Residence does not put Multiverse-Core as a softdepend in its plugin.yml, probably because they wanted to make the multiword plugin a setting (in their config.yml) but as a result you get this weird behavior where it is breaking the enable ordering and disregarding the load ordering contract that plugins have with the server. They should not be doing that because it now forces all plugins that must load before Multiverse to also now put Residence as a loadbefore item. Hmm. Here's a BentoBox with Residence as a loadbefore (or you can edit the plugin.yml yourself). Please try it and confirm. |
Yikes! I confirm that the errors are gone. Why do people do this? It would be so simple for Residence to specify loadbefore. Will you post the issue, or shall I? |
I'll file a bug report and let's see if they can fix this. |
Thanks. They certainly can. I hope they will. They have not been responsive to the issues I have filed; not even comments. :( |
It's because they're no longer working on this repo. They're using this one: https://github.com/Zrips/Residence/issues |
That's the repo I use. Of the 20 most-recently updated, only 8 have comments (and not all by the devs). :( |
I'll close this bug for now but we can see if anything comes of the ones I posted. |
@SlimeDog Zrips fixed the bug. |
Description
BentoBox is reported as not enabled on start-up, twice for each BSkyBlock world.
Steps to reproduce the behavior:
Log (partial)
Server Information:
The text was updated successfully, but these errors were encountered: