Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confirmation always needed #531

Closed
LikeABoss9 opened this issue Feb 8, 2019 · 4 comments
Closed

confirmation always needed #531

LikeABoss9 opened this issue Feb 8, 2019 · 4 comments
Assignees
@tastybento
Labels
Type: Bug
Milestone
1.3.0

Comments

@LikeABoss9
Copy link

regardless of how this function is set, you must always confirm.

image
@Poslovitch
Copy link
Member

Please fill in the template: https://github.com/BentoBoxWorld/BSkyBlock/blob/master/.github/ISSUE_TEMPLATE/bug_report.md

@tastybento tastybento self-assigned this Feb 9, 2019
@tastybento
Copy link
Member

I would normally want a template completion here, but I understand the issue so I'll accept it.

@tastybento tastybento transferred this issue from BentoBoxWorld/BSkyBlock Feb 9, 2019
@tastybento tastybento added this to the 1.3.0 milestone Feb 9, 2019
@tastybento
Copy link
Member

tastybento commented Feb 9, 2019 •
edited

Currently cooldowns and confirmation settings are in the BentoBox config.yml. They need to be pulled out of the the GameMode settings. I'll clean it up.

tastybento added a commit to BentoBoxWorld/AcidIsland that referenced this issue Feb 9, 2019
@tastybento
Removes extraneous settings.
2d31b96 
BentoBoxWorld/BentoBox#531
tastybento added a commit to BentoBoxWorld/BSkyBlock that referenced this issue Feb 9, 2019
@tastybento
Removes extraneous settings
e60ab11 
BentoBoxWorld/BentoBox#531
tastybento added a commit to BentoBoxWorld/CaveBlock that referenced this issue Feb 9, 2019
@tastybento
Removes extraneous settings
f42c15e 
BentoBoxWorld/BentoBox#531
@tastybento
Copy link
Member

@LikeABoss9 This setting is in the BentoBox config.yml because it's a global setting for all game modes. Thanks for the report.

BONNe added a commit to BentoBoxWorld/CaveBlock that referenced this issue Mar 5, 2019
@BONNe
Merge develop into master (#15)
446087a 
* Fixes BEETROOT_SEEDS enum for itemstack in schem

#12

* Adds error checking for MATERIALs in config.yml

MATERIALs must be blocks otherwise the world populator will throw errors
and crash the server. This commit checks that all imported materials are
blocks and if they are not logs the error.

Updated config.yml to use correct 1.13 material names for blocks.

#11

* Removes extraneous settings

BentoBoxWorld/BentoBox#531

* Implement ability to change user and admin command in config.

* Improve CaveBlock pom.xml

Remove unnecessary things.
Add dependency projects in properties
Add BuildNumber to version tag.

* Add BentoBox 1.3.0 admin commands

* Remove BeaconEnabler as it is not necessary.
Beacon can shine through bedrock.

Update pom as Challenges addon.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Type: Bug
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
3 participants
@tastybento @Poslovitch @LikeABoss9