Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LingeringPotionSplashEvent error #810

Closed
myavuzokumus opened this issue Jul 3, 2019 · 10 comments
Closed

LingeringPotionSplashEvent error #810

myavuzokumus opened this issue Jul 3, 2019 · 10 comments
Assignees
@tastybento
Labels
1.14 Related to 1.14+ Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone
1.6.0

Comments

@myavuzokumus
Copy link
Contributor

myavuzokumus commented Jul 3, 2019 •
edited by Poslovitch
Loading

Description

Describe the bug

image

Environment

Server

  • OS: Windows
  • Java version: Java 8

Plugins

image

BentoBox setup

BentoBox and Addons

image
@myavuzokumus myavuzokumus added Status: Pending Waiting for a developer to start working on this issue. Type: Bug labels Jul 3, 2019
@myavuzokumus myavuzokumus changed the title A mistake I don't know LingeringPotionSplashEvent error Jul 3, 2019
@Poslovitch Poslovitch added the 1.14 Related to 1.14+ label Jul 3, 2019
@Poslovitch Poslovitch self-assigned this Jul 4, 2019
@Poslovitch Poslovitch added Status: In progress Working on the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Jul 4, 2019
@Poslovitch Poslovitch added this to the 1.6.0 milestone Jul 4, 2019
@Poslovitch
Copy link
Member

I don't understand this error, the code we're using is absolutely fine with abstraction there. We're not getting a LingeringPotion at any place, just Projectile, which is also extended by the new object they use: ThrownPotion. This just doesn't make any sense.

Could you please try updating your server version? I'm pretty sure it's a server side issue...

@Poslovitch Poslovitch added Type: Not a bug Works as intended / not a BentoBox bug. Status: Need answer Waiting for more information to be provided by the issue's author. and removed Type: Bug Status: In progress Working on the issue. labels Jul 4, 2019
@myavuzokumus
Copy link
Contributor Author

myavuzokumus commented Jul 4, 2019 •
edited
Loading

I've updated bentobox to the latest dev version, and after updating the paper I think the error has improved. I've never received such a mistake today.

Edit: The error happened again.

@Poslovitch
Copy link
Member

Could you please provide the stacktrace of the error that still happens? I'd like to know if something changed in the meantime.

@myavuzokumus
Copy link
Contributor Author

myavuzokumus commented Jul 4, 2019 •
edited by tastybento
Loading 

 [14:48:43] [Server thread/ERROR]: Could not pass event LingeringPotionSplashEvent to BentoBox v1.6.0-SNAPSHOT-b1231
java.lang.NoSuchMethodError: org.bukkit.event.entity.LingeringPotionSplashEvent.getEntity()Lorg/bukkit/entity/LingeringPotion;
	at world.bentobox.bentobox.listeners.flags.protection.HurtingListener.onLingeringPotionSplash(HurtingListener.java:157) ~[?:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor66.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.14.3.jar:git-Paper-123]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.14.3.jar:git-Paper-123]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.14.3.jar:git-Paper-123]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:536) ~[patched_1.14.3.jar:git-Paper-123]
	at org.bukkit.craftbukkit.v1_14_R1.event.CraftEventFactory.callLingeringPotionSplashEvent(CraftEventFactory.java:686) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.EntityPotion.a(EntityPotion.java:215) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.EntityPotion.a(EntityPotion.java:90) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.EntityProjectile.tick(EntityProjectile.java:118) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.WorldServer.entityJoinedWorld(WorldServer.java:579) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.World.a(World.java:933) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.WorldServer.doTick(WorldServer.java:354) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1192) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:420) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1064) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:908) ~[patched_1.14.3.jar:git-Paper-123]
	at java.lang.Thread.run(Unknown Source) [?:1.8.0_211]
[14:48:43] [Server thread/ERROR]: Could not pass event LingeringPotionSplashEvent to BentoBox v1.6.0-SNAPSHOT-b1231
java.lang.NoSuchMethodError: org.bukkit.event.entity.LingeringPotionSplashEvent.getEntity()Lorg/bukkit/entity/LingeringPotion;
	at world.bentobox.bentobox.listeners.flags.settings.PVPListener.onLingeringPotionSplash(PVPListener.java:166) ~[?:?]
	at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor87.execute(Unknown Source) ~[?:?]
	at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.14.3.jar:git-Paper-123]
	at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.14.3.jar:git-Paper-123]
	at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.14.3.jar:git-Paper-123]
	at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:536) ~[patched_1.14.3.jar:git-Paper-123]
	at org.bukkit.craftbukkit.v1_14_R1.event.CraftEventFactory.callLingeringPotionSplashEvent(CraftEventFactory.java:686) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.EntityPotion.a(EntityPotion.java:215) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.EntityPotion.a(EntityPotion.java:90) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.EntityProjectile.tick(EntityProjectile.java:118) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.WorldServer.entityJoinedWorld(WorldServer.java:579) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.World.a(World.java:933) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.WorldServer.doTick(WorldServer.java:354) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1192) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:420) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1064) ~[patched_1.14.3.jar:git-Paper-123]
	at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:908) ~[patched_1.14.3.jar:git-Paper-123]
	at java.lang.Thread.run(Unknown Source)

@Poslovitch Poslovitch added Status: Under investigation Investigating the interest and the feasability of the issue. and removed Status: Need answer Waiting for more information to be provided by the issue's author. labels Jul 4, 2019
@tastybento
Copy link
Member

I've replicated this issue with Paper and regular Spigot 1.14.3.

@tastybento tastybento added Type: Bug and removed Type: Not a bug Works as intended / not a BentoBox bug. labels Jul 6, 2019
@tastybento tastybento assigned tastybento and unassigned Poslovitch Jul 6, 2019
@tastybento
Copy link
Member

@Poslovitch I've tried and there's no way to fix this. If the BentoBox code is compiled using the 1.14.3 Spigot API in the POM then it works in 1.14.3 but causes errors in 1.13.2. If it's compiled using 1.13.2 API then it'll cause errors in 1.14.3. I'm trying now to see if there's a workaround.

@tastybento
Copy link
Member

Yeah, I can't find one right now. I was playing with ProjectileLaunchEvent, so it could potentially be used to block harmful lingering potions from being thrown if you are a visitor and PVP isn't active. Something like that. Thoughts?

@tastybento
Copy link
Member

Filed a bug with Spigot here: https://hub.spigotmc.org/jira/browse/SPIGOT-5167

@tastybento
Copy link
Member

@Poslovitch The outcome of the spigot bug looks like this will not be fixed. This means we either have to remove this functionality, just make it operate only in one version of the server, or have two jars compiled separately. I'm thinking maybe the middle option.

@Poslovitch
Copy link
Member

Middle option

tastybento added a commit that referenced this issue Jul 14, 2019
@tastybento
Removes Lingering Splash Potion protection from 1.14 for now.
6bbe9a3 
Will be put back in when we move to 1.14 officially.

#810
@tastybento tastybento removed the Status: Under investigation Investigating the interest and the feasability of the issue. label Jul 14, 2019
@tastybento tastybento added the Status: Done This issue has been completed or answered. This pull request has been merged. label Jul 14, 2019
@tastybento tastybento mentioned this issue Jul 29, 2019
Closed
@BONNe BONNe mentioned this issue Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
1.14 Related to 1.14+ Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
3 participants
@tastybento @Poslovitch @myavuzokumus