Biomes settings

[Nedjii]

Hello, we can define who can change the biome of the island in /is settings but we can't define by default who has the permission to do that in the config,
regards.

[tastybento]

No, that's correct. Perms are preset. Here's a list for BSkyBlock:

permissions:
  bskyblock.biomes:
    description: Player can use biomes command that opens GUI.
    default: true
  bskyblock.biomes.info:
    description: Player can use biomes info command.
    default: true
  bskyblock.biomes.set:
    description: Player can use biomes set command.
    default: true

[Nedjii]

I'm not talking about vault permissions but island rank permission, who can or cannot change something on the is, most of settings in the /is settings can be defined by default in the config, the setting for the biome change isn't in the config. We can change it using the /is settings GUI but we can't st by default which role on the island can do this.

[tastybento]

Okay. Biomes addon registers two flags with BentoBox, a world setting flag called BIOMES_WORLD_PROTECTION and an advanced protection flag called BIOMES_ISLAND_PROTECTION. You should just be able to add BIOMES_ISLAND_PROTECTION manually to the default setting section of config.yml. Note, it'll only affect new islands.

[Nedjii]

I'm talking about "default-island-flags:" and not "flags".
You can't define which role can change the island biome by default in the config using numbers 50, 900 etc.

[BONNe]

You should just be able to add BIOMES_ISLAND_PROTECTION manually to the default setting section of config.yml. Note, it'll only affect new islands.

By config.yml tasty meant not biomes addon config, but BSkyBlock config.

[Nedjii]

I'm aware, there is still no way in this config to define which role can change the island biome by default.

[BONNe]

  default-island-flags:
    BIOMES_ISLAND_PROTECTION: 500

[Nedjii]

I already tried to put 900 and that changed nothing, it's still member as by default.

[tastybento]

Yes, the default setting is not being accepted. I'll investigate.

[tastybento]

To fix we need GameModeAddons to reload their settings after all addons have loaded. Although there is an event that can be listened for, it is better to have a new BentoBox API in the GameModeAddon class that will be called explicitly. This will then enable the game mode addon to reload settings and accept the flag.

Here is why: it is due to timing:

1. When the server starts, BentoBox loads BSkyBlock. During this time, if any flags are loaded from config.yml by BSkyBlock that are unknown, they are discarded. Further, BSkyBlock then saves the config.yml and the flag is completely lost.
2. BentoBox then loads Biomes - this is dependent on BSkyBlock so it cannot be loaded before it.
3. Biomes register the flags.

With the new API, the following occurs:

1. When the server starts, BentoBox loads BSkyBlock
2. BSkyBlock loads config.yml. Addon flags will be lost temporarily. BSkyBlock will not save the config at this point.
3. BentoBox then loads Biomes - this is dependent on BSkyBlock so it cannot be loaded before it.
4. Biomes register the flags.
5. BentoBox finishes loading all the addons and calls the new GameModeAddon#allLoaded() method.
6. BSkyBlock reloads config.yml and this time the Biomes flag is known and kept.
7. BSkyBlock saves config.yml and the flag is kept.

[tastybento]

That should fix it. @BONNe Could you review and confirm?