-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset health, hunger and XP when resetting the island #958
Comments
For xp and health, that would be a feature request - both of those are not reset, no. |
Thanks for the reply, |
You already did. This is the one.
So you want an option (@tastybento I guess it should be gamemode based?) to specify a default amount of money? @tastybento This might cause issues with our current implementation, with which we do not support world-specific money, whereas Vault can do. We might need to slightly adapt our VaultHook to suit the needs of this feature request. |
Yes exactly ^^ for exemple a line on the configuration file ("starting-money: " for example) |
We had starting money in ASkyBlock. Let me noodle on this. |
@tastybento So, I guess we're not doing world-based economy support for now? I'll open a ticket then. |
That's a good point. Unless there is a world-based economy in place, then any setting of money will affect all game modes. |
XP, hunger and health sound okay to me.
Vault can support that, but I'll definitely open a ticket for it, as it might require some more thoughts. |
Another concern of this issue: it will require to add new methods in the WorldSettings, so it might break gamemode addons snapshots, once again ^^'. I'll also open another issue for the "starter-money" feature request @tastybento. |
Agreed. 1.8.0 has already crossed that point so it’s okay to do it again. Let’s just time it so that the addons are updated concurrently. |
Implements #958 Added the following methods in WorldSettings and IslandWorldManager: * #isOnJoinResetHealth() * #isOnJoinResetHunger() * #isOnJoinResetXP() * #isOnLeaveResetHealth() * #isOnLeaveResetHunger() * #isOnLeaveResetXP()
Gamemode Addons will need to implement the newly added WorldSettings methods. |
Implemented. While working on this, I stumbled upon excessive code duplication. We'll need to address that at some point. |
Description
Describe the bug
When you reset an island, the heal and xp and hunger do not reset. The money does not come at a value we would like
Steps to reproduce the behavior
You just have to reset the island, for example if the player took damage or lost hunger, if he reset his island he will always have his stats on his new island.
Screenshots and videos
Expected behavior
I do not think this is a bug but a configuration line that is not in my configuration file.
Environment
Server
Plugins
BentoBox setup
BentoBox and Addons
Configuration
Additional context
The text was updated successfully, but these errors were encountered: