Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering a user to the spawn island doesn't change its status as a spawn island #991

Closed
tastybento opened this issue Oct 18, 2019 · 2 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Milestone

Comments

@tastybento
Copy link
Member

Description

Describe the bug

Registering a user to the spawn island doesn't change its status as a spawn island.

Steps to reproduce the behavior

  1. Set an island to be spawn: /bsb setspawn
  2. Do /bsb info to see that it is unowned and a spawn island
  3. Register it to a player: /bsb register tastybento
  4. Do /bsb info to see that it is owned and a spawn island
  5. Do /bsb setspawn and it will say it is already a spawn island.

Expected behavior

If a spawn island is registered to a user, then it should become that player's island and not be the spawn island.

@Poslovitch Poslovitch added the Status: Pending Waiting for a developer to start working on this issue. label Oct 18, 2019
@Poslovitch
Copy link
Member

The admin should be told about such behaviour. Might be worth adding a confirmation message.

@Poslovitch Poslovitch added this to the 1.8.0 milestone Oct 18, 2019
@tastybento tastybento self-assigned this Oct 19, 2019
@tastybento tastybento added Status: In progress Working on the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Oct 19, 2019
tastybento added a commit that referenced this issue Oct 19, 2019
@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Oct 19, 2019
@wellnesscookie
Copy link
Contributor

wellnesscookie commented Jan 6, 2020

Sorry for bumping, but I am afraid this change does not allows me anymore to both set the island as a spawn and keep it registered to a user. Problem is that we use specific range on the spawn island because our spawn is of enormous size and range setting is essential. But since this change we must have a bigger border, yet our skyblock has no island spawn defined anymore.

I believe the island spawn is essential to some of /is expel or similar commands.
This 'bug' had been flagged as 'not a bug' earlier in #990 , but it probably got forgotten.

I have seen no bad outcomes of this feature, as I call it, at least we used it as such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Development

No branches or pull requests

3 participants