Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credits GUI for BentoBox and Addons #993

Closed
Poslovitch opened this issue Oct 20, 2019 · 2 comments
Closed

Credits GUI for BentoBox and Addons #993

Poslovitch opened this issue Oct 20, 2019 · 2 comments
Assignees
@Poslovitch
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Milestone
1.9.0 - SpigotMC ...

Comments

@Poslovitch
Copy link
Member

Poslovitch commented Oct 20, 2019 •
edited
Loading

Description

Is your feature request related to a problem?

No.

Describe the solution you'd like us to implement.

Implement a Credits GUI for BentoBox (in /bbox manage) and for each addons (in both /bbox manage and the Catalog).
If GitHub is available, it will gather the data from here and display commits, etc...
Otherwise it will just display the authors from the addon.yml.

The Language Panel already do such thing (it credits the translators), so I thought developers should be credited as well.

Describe alternatives you've considered.

None.

Additional context

None.
@Poslovitch Poslovitch added Type: Enhancement Improvement or modification which is usually a new feature. Status: Pending Waiting for a developer to start working on this issue. labels Oct 20, 2019
@Poslovitch Poslovitch added this to the 1.9.0 - SpigotMC release! milestone Oct 20, 2019
@Poslovitch Poslovitch changed the title Add Credits for BentoBox and Addons Credits GUI for BentoBox and Addons Oct 20, 2019
@Poslovitch Poslovitch added Status: In progress Working on the issue. and removed Status: Pending Waiting for a developer to start working on this issue. labels Oct 22, 2019
@Poslovitch Poslovitch self-assigned this Oct 22, 2019
@Poslovitch
Copy link
Member Author

Nearly finished. I need to do a few more tweaks before pushing it.

@Poslovitch Poslovitch mentioned this issue Oct 24, 2019
Merged
Poslovitch added a commit that referenced this issue Oct 24, 2019
@Poslovitch
Added Credits GUI for addons and BentoBox
551975d 
Implements #993
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: In progress Working on the issue. labels Oct 24, 2019
@Poslovitch
Copy link
Member Author

And this is how the BentoBox Credits look like thanks to @YellowZaki's fix (#1007):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Poslovitch Poslovitch

Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Milestone
1.9.0 - SpigotMC release!
Development

No branches or pull requests
1 participant
@Poslovitch