Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LIMIT_MOBS flag (WORLD_SETTING) #1155

Merged
merged 1 commit into from Feb 16, 2020
Merged

Conversation

tastybento
Copy link
Member

@tastybento tastybento commented Jan 28, 2020

It requires game modes to support the feature but it will not break if they don't. The menu will just not work.
#1133

but will not break if they dont.
#1133
@tastybento tastybento added the Type: Enhancement Improvement or modification which is usually a new feature. label Jan 28, 2020
tastybento added a commit to BentoBoxWorld/BSkyBlock that referenced this pull request Jan 28, 2020
@tastybento tastybento self-assigned this Jan 28, 2020
@tastybento tastybento changed the title Requires game modes to support the feature Limits global mob spawning by type Jan 28, 2020
@Poslovitch
Copy link
Member

Please wait until we reach 1.12.0 development before merging.

@Poslovitch Poslovitch added the Status: Need review Waiting for a review to be made on this Pull Request label Jan 28, 2020
@Poslovitch Poslovitch added this to the 1.12.0 milestone Jan 28, 2020
@Poslovitch Poslovitch linked an issue Feb 4, 2020 that may be closed by this pull request
@tastybento
Copy link
Member Author

@Poslovitch Okay to merge in now?

@Poslovitch
Copy link
Member

Give me some time to review it, and I'll merge it ;)

@Poslovitch
Copy link
Member

It's good, however it doesn't fulfill entirely the request of #1133. But it's a good step forward.

@Poslovitch Poslovitch changed the title Limits global mob spawning by type Added LIMIT_MOBS flag (WORLD_SETTING) Feb 16, 2020
@Poslovitch Poslovitch merged commit 06b5aac into develop Feb 16, 2020
@Poslovitch Poslovitch deleted the 1133_mob_spawn_limiting branch February 16, 2020 12:12
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Need review Waiting for a review to be made on this Pull Request labels Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case By Case Entity Spawn Blocking
3 participants