Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags for Block Explode #1899

Merged
merged 5 commits into from Jan 2, 2022
Merged

Flags for Block Explode #1899

merged 5 commits into from Jan 2, 2022

Conversation

HSGamer
Copy link
Contributor

@HSGamer HSGamer commented Dec 25, 2021 •
edited

close #1883

@BONNe
Copy link
Member

BONNe commented Dec 25, 2021

I disagree with adding it in TNT damage flag.
I think it would be better to be a separate flag or flags.

@HSGamer HSGamer changed the title add Block Explosion support for TNT_DAMAGE flag Flags for Block Explode Dec 25, 2021
@HSGamer
Copy link
Contributor Author

HSGamer commented Dec 25, 2021

I disagree with adding it in TNT damage flag. I think it would be better to be a separate flag or flags.

Now there are separated flags

@BONNe
Copy link
Member

BONNe commented Dec 25, 2021

One more thing... your events are in TNT listener. Just a bit weird that the listener is linked to a flag that is not using these checks.
I would prefer it to be a separate listener.

But it is not up to me :D I am not a tastybento or poslovitch :D

@HSGamer
Copy link
Contributor Author

HSGamer commented Dec 25, 2021

One more thing... your events are in TNT listener. Just a bit weird that the listener is linked to a flag that is not using these checks. I would prefer it to be a separate listener.

But it is not up to me :D I am not a tastybento or poslovitch :D

It's up to them to decide whether or not this should be in a seperated listener. I heard about the test class, so I don't touch that.

@HSGamer
Copy link
Contributor Author

HSGamer commented Dec 25, 2021

At this point, this PR will close #1883

@tastybento
Copy link
Member

Once this merges, I'll need to fix the tests.

@tastybento tastybento merged commit 7088a27 into BentoBoxWorld:develop Jan 2, 2022
@renovate renovate bot mentioned this pull request Feb 19, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BONNe BONNe BONNe left review comments

@tastybento tastybento tastybento approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dont have protection for explosion
3 participants
@HSGamer @BONNe @tastybento