Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This changes the loading to not be on STARTUP #2214

Merged
merged 2 commits into from
Oct 29, 2023
Merged

This changes the loading to not be on STARTUP #2214

merged 2 commits into from
Oct 29, 2023

Conversation

tastybento
Copy link
Member

Worlds are then created in onEnable and not one-tick later. This provides compatibility with Residence plugin. See #2213

@tastybento
This changes the loading to not be on STARTUP
3d81de5 
Worlds are then created in onEnable and not one-tick later.
@tastybento
Copy link
Member Author

This needs more testing to see if this causes any issues. There was a reason why we used to load at STARTUP, but maybe it's not needed anymore?

@tastybento tastybento requested a review from BONNe October 22, 2023 20:39
@tastybento tastybento linked an issue Oct 22, 2023 that may be closed by this pull request
Residence incompatibility #2213
Closed
tastybento
tastybento commented Oct 22, 2023
View reviewed changes
src/main/java/world/bentobox/bentobox/BentoBox.java
e.printStackTrace();
}
});
//Bukkit.getScheduler().runTask(instance, () -> {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commented out for now.

@BONNe
Copy link
Member

BONNe commented Oct 23, 2023

This needs more testing to see if this causes any issues. There was a reason why we used to load at STARTUP, but maybe it's not needed anymore?

STARTUP was requested for single-world on-server setups.

@BONNe
Copy link
Member

BONNe commented Oct 23, 2023

Also, as it is not delayed anymore, will it still properly register Placeholders to PAPI?

@tastybento
Copy link
Member Author

I’ll test PAPI.

I don’t understand the first comment though. Can you explain more please?

@BONNe
Copy link
Member

BONNe commented Oct 23, 2023

I don’t understand the first comment though. Can you explain more please?

In server.properties world is set to bskyblock_world

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tastybento
Copy link
Member Author

I don’t understand the first comment though. Can you explain more please?

In server.properties world is set to bskyblock_world

@BONNe I tried this and it all seems to work okay. What was the particular issue with this setup?

@BONNe
Copy link
Member

BONNe commented Oct 28, 2023

No, I did not have any issues.

@tastybento tastybento merged commit 4a6bf31 into develop Oct 29, 2023
3 checks passed
@tastybento tastybento deleted the no_startup_loading_2213 branch October 29, 2023 04:16
@tastybento
Copy link
Member Author

Okay let's try it and see if anyone has a problem.

tastybento added a commit that referenced this pull request Nov 10, 2023
@tastybento
Revert "This changes the loading to not be on STARTUP (#2214)"
c63de27 
This reverts commit 4a6bf31.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BONNe BONNe Awaiting requested review from BONNe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Residence incompatibility
2 participants
@tastybento @BONNe