Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable Island Creation Panel #2255

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Conversation

BONNe
Copy link
Member

@BONNe BONNe commented Jan 2, 2024

This implements customizable Island Creation Panel. By default, panel is generated in /plugins/bentobox/panels folder, however, if GameModeAddon has a specific panel defined in their folder, then that panel is taken.

This implements customizable Island Creation Panel. By default, panel is generated in `/plugins/bentobox/panels` folder, however, if GameModeAddon has a specific panel defined in their folder, then that panel is taken.
@BONNe BONNe marked this pull request as draft January 2, 2024 13:56
@BONNe BONNe marked this pull request as ready for review January 4, 2024 07:40
@BONNe BONNe requested a review from tastybento January 4, 2024 07:40
@BONNe
Copy link
Member Author

BONNe commented Jan 4, 2024

Hi @tastybento

This is a fully implemented customizable island selection panel for users. I also implemented the unit test, but I am unsure if it tests everything. But for me, it passed.

@BONNe BONNe changed the title WIP: Customizable Island Creation Panel Customizable Island Creation Panel Jan 4, 2024
@tastybento tastybento merged commit bfb4873 into develop Jan 4, 2024
1 check passed
@BONNe BONNe deleted the island_creation_panel branch January 4, 2024 08:19
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

18.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants