Fixes ItemParser.

[BONNe]

Implements new Potion and Skull parsing.
Fixes custom model data parsing.
Implements ItemFactory#createItemStack parsing that parses item using /give syntax.

Solves some issues mentioned in #2198

[tastybento]

There's one test that's failing, which is world.bentobox.bentobox.api.localization.BentoBoxLocaleTest#testGetBanner.

This is a pretty simple test that should be able to generate a banner from Yaml.

        YamlConfiguration config = new YamlConfiguration();
        config.set("meta.banner", "WHITE_BANNER:1:STRIPE_SMALL:RED:SQUARE_TOP_RIGHT:CYAN:SQUARE_TOP_RIGHT:BLUE");

The issue is that right now, when this class runs it tries:

        // Load the banner from the configuration
        banner = ItemParser.parse(config.getString("meta.banner"));

But the return is null. Any idea what?

[BONNe]

I solved it. The issue was that IllegalArgumentException was not thrown because of mocked class.

[sonarcloud]

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
58.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud