Remove unnecessary checks in IslandsManager and IslandWorldManager. #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed checks overlaps a lot. It is not necessary to check multiple time if island is nether and end island, as they will not change their status in runtime.
Poslovitch
added
Status: Need review
|
Thanks @BONNe . These changes make sense. The history is that the World/GameModes map originally only held the normal world and not the nether and end, so that's why there were these convoluted checks. Then we moved to storing all three of the worlds in the map but did not change the checking code. |
tastybento
approved these changes
May 22, 2019
Poslovitch
approved these changes
May 23, 2019
Poslovitch
added
Status: Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed checks overlaps a lot. It is not necessary to check multiple time if island is nether and end island, as they will not change their status in runtime.
THIS WILL BREAK SOME TESTS.
But not because changes are not correct, but because tests are incorrect. They set #inWorld(World) to always return true.
Found this by investigating #676.
getIslandAt(Location) optimization is correct, as inWorld(World) already checked all these options that is required for world to be an Island World.
inWorld(World) can be optimized even more, by creating local object that contains worldSettings, to avoid getting element from map in isIslandNether(World) and isIslandEnd(World).