Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved handling of click events for Panels #730

Merged
merged 1 commit into from Jun 5, 2019
Merged

Improved handling of click events for Panels #730

merged 1 commit into from Jun 5, 2019

Conversation

BONNe
Copy link
Member

@BONNe BONNe commented Jun 5, 2019 •
edited

Canceling event should happen as fast as possible.
Even if GUI will be closed as otherwise clicked items may appear in players inventory.

This should fix #725

@BONNe BONNe changed the title Event Cancel movement. Inventory Click Event Canceling Jun 5, 2019
@Poslovitch Poslovitch added Status: Need review Waiting for a review to be made on this Pull Request Type: Bug labels Jun 5, 2019
@Poslovitch Poslovitch requested review from Poslovitch and removed request for tastybento June 5, 2019 12:57
Poslovitch
Poslovitch approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Need review Waiting for a review to be made on this Pull Request labels Jun 5, 2019
@Poslovitch Poslovitch added this to the 1.5.0 milestone Jun 5, 2019
@Poslovitch Poslovitch changed the title Inventory Click Event Canceling Improved handling of click events for Panels Jun 5, 2019
@Poslovitch Poslovitch merged commit 0dee0ed into BentoBoxWorld:develop Jun 5, 2019
@Poslovitch
Copy link
Member

Thanks for the fix @BONNe ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Poslovitch Poslovitch Poslovitch approved these changes

Assignees
No one assigned
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BONNe @Poslovitch