Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fishes can be picked up by buckets #349

Closed
Poslovitch opened this issue Nov 19, 2018 · 5 comments
Closed

Fishes can be picked up by buckets #349

Poslovitch opened this issue Nov 19, 2018 · 5 comments
Assignees
@tastybento
Labels
Type: Bug

Comments

@Poslovitch
Copy link
Member

Description
Splited from #336.
According to @Kryniowesegryderiusz,

  • Fishes can be picked up by buckets.

Server Information:

  • Database being used (Flat file, MySQL, Mongo): MySQL
  • OS: Ubuntu
  • Java Version: 8
  • BentoBox version: 0.14.0
  • Addons installed?
BSkyBLock 0.5.0
WelcomeWarps 0.1.0
Level 0.1.0
Challenges 0.0.3
@Poslovitch Poslovitch added the Status: Under investigation Investigating the interest and the feasability of the issue. label Nov 19, 2018
@tastybento tastybento self-assigned this Nov 20, 2018
@tastybento tastybento added Status: Cannot replicate Could not replicate the issue on a fresh install. More details are needed. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Nov 20, 2018
@tastybento
Copy link
Member

I cannot replicate this. If bucket use and collect water are disallowed for visitors then you cannot collect a fish in a bucket.

@tastybento
Copy link
Member

@Kryniowesegryderiusz Can you give any more info on how to replicate?

@tastybento tastybento added the Status: Need answer Waiting for more information to be provided by the issue's author. label Nov 20, 2018
@Kryniowesegryderiusz
Copy link

In 1.13 you have to have bucket with water to pick up fish

@tastybento
Copy link
Member

Okay, thanks I got it. There must be water in the bucket. I was trying with an empty bucket.

@tastybento tastybento added Type: Bug and removed Status: Cannot replicate Could not replicate the issue on a fresh install. More details are needed. Status: Need answer Waiting for more information to be provided by the issue's author. labels Nov 20, 2018
tastybento added a commit that referenced this issue Nov 21, 2018
@tastybento
Fixes protection for scooping tropical fish.
ff29836 
#349

Also added pagination to protection flags and localized alphabetical
sorting of the flags.

Also added defensive code should a flag enum be removed but it is still
in the island database. In this case it will just be ignored and at the
next database object save it will disappear.
@tastybento
Copy link
Member

Okay fixed. This had a domino effect on the overall settings panel because I added a new flag and it was more than what could be shown so I added pagination to the settings panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tastybento @Kryniowesegryderiusz @Poslovitch