Update run_bepinex.sh #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
notfood
commented
Jul 10, 2020
notfood
commented
- Allows paths with spaces
- Will warn and exit if there is no executable, not just the argument, no need to remove any lines after configuring it
- Removed unnecesary ;
- Allows paths with spaces - Will warn and exit if there is no executable, not just the argument, no need to remove any lines after configuring it - Removed unnecesary ;
|
Great, thank you! What OSes was this tested on? Primary special cases we have to look for is
I'll give a test on each platform that wasn't tested yet. If it looks good, I'll merge it. |
|
I have only been able to test
|
ghorsington
requested changes
Jul 10, 2020
ghorsington
reviewed
Jul 10, 2020
|
Added some changes to resolve the raised issues. I can't test properly against macOS. |
|
Perfect, I'll have it tested asap just one more time |
ghorsington
approved these changes
Jul 10, 2020
|
This is now available in bleeding edge builds Thank you very much for cleaning up the start script! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.