Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for async streaming to watsonx provider #3479

Merged

Conversation

simonsanvil
Copy link
Contributor

@simonsanvil simonsanvil commented May 6, 2024

Type

🆕 New Feature
🐛 Bug Fix

Changes

Mainly changes main.py, utils.py, and llms/watsonx.py to return coroutines / async generators to support asynchronous completions and streaming completions. Also fixes a bug with the ibm_granite_pt prompt template not being complete.

Testing

pytest litellm/tests/test_completion.py -k watsonx

  • Tested on MacOS

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 3:46pm

@krrishdholakia krrishdholakia merged commit 3f13251 into BerriAI:main May 9, 2024
2 checks passed
@krrishdholakia
Copy link
Contributor

krrishdholakia commented May 9, 2024

Hi @simonsanvil i had to revert this PR as it failed our linting tests - https://app.circleci.com/pipelines/github/BerriAI/litellm/9452/workflows/9c769768-2d24-4534-9416-6ef9919e9eb9/jobs/20403

Can you please fix the issues and resubmit?

Thank you for the help on this

Here is how our linting test runs -

name: Linting Testing

cd litellm && python -m mypy . --ignore-missing-imports

@simonsanvil
Copy link
Contributor Author

@krrishdholakia Fixed in #3561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants