Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Fixed linting and other bugs with watsonx provider #3561

Merged
merged 3 commits into from
May 11, 2024

Conversation

simonsanvil
Copy link
Contributor

@simonsanvil simonsanvil commented May 10, 2024

Fixed linting and minor bugs with watsonx provider

Relevant issues

Fixes the linting issues raised in #3479

Type

πŸ› Bug Fix
βœ… Test

Changes

  • Fixed typing for context manager class and other arguments.
  • Added test for streaming completion/acompletion w/ watsonx provider.
  • Fixed the last chunk of a streaming response not returning usage.
  • Improved error messages

Testing

pytest litellm/tests/test_completion.py -k "watsonx"

Linting:

cd litellm && python -m mypy . --ignore-missing-imports

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
litellm βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 10, 2024 10:17am

@simonsanvil simonsanvil changed the title (fix) Fixed linting and minor bugs with watsonx provider (fix) Fixed linting and other bugs with watsonx provider May 11, 2024
@krrishdholakia krrishdholakia merged commit d33e494 into BerriAI:main May 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants