Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests & Fix CNAME support #1033

Merged
merged 3 commits into from
May 22, 2024

deduplicate a bunch of code

94ee623
Select commit
Loading
Failed to load commit list.
Merged

Improve tests & Fix CNAME support #1033

deduplicate a bunch of code
94ee623
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 22, 2024 in 1s

23.18% (-0.33%) compared to d11ac22

View this Pull Request on Codecov

23.18% (-0.33%) compared to d11ac22

Details

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 23.18%. Comparing base (d11ac22) to head (94ee623).

Files Patch % Lines
pkg/roles/api/role.go 0.00% 2 Missing ⚠️
pkg/roles/dns/handler_etcd.go 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
- Coverage   23.51%   23.18%   -0.33%     
==========================================
  Files         215      214       -1     
  Lines       15661    15643      -18     
==========================================
- Hits         3682     3627      -55     
- Misses      11554    11590      +36     
- Partials      425      426       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.