Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

首句歌词时间戳异常 #65

Closed
ish-kafel opened this issue Feb 26, 2020 · 7 comments · Fixed by #67
Closed

首句歌词时间戳异常 #65

ish-kafel opened this issue Feb 26, 2020 · 7 comments · Fixed by #67
Labels
bug Something isn't working
Milestone
v3.1.2

Comments

@ish-kafel
Copy link

刚做了一首歌，音乐一开始就是第一句歌词，在默认提前300ms的情况下，最终生成第一句的时间戳为[-909387743:51.524]，导致需要手动修改。希望可以给首句时间加个判断，小于0就插入[00:00.000]
@ish-kafel
Copy link
Author

我使用的windows的3.1.1版本

@BensonLaur BensonLaur added the bug Something isn't working label Feb 26, 2020
@BensonLaur
Copy link
Member

感谢反馈，应该是你提到的情况没有处理

@BensonLaur
Copy link
Member

BensonLaur commented Feb 26, 2020 •
edited by pzhlkj6612

进一步发现应该 是记录时间的变量 curAudioPos 还没来得及被初始化就推上标记了一行导致

https://github.com/Beslyric-for-X/Beslyric-for-X/blob/4ad293c041559d1aaa17d9517f97129b2586703a/MiddleWidgets/SubPageMaking.cpp#L489-L495

@ish-kafel
Copy link
Author

应该是，我点完开始制作马上就按了上键推上

BensonLaur added a commit that referenced this issue Feb 26, 2020
@BensonLaur
修复首句歌词时间戳标记异常问题
8b5141f 
相关 issue #65
@pzhlkj6612
Copy link
Member

8b5141f 的修复似乎没找到关键点，等会我做个提交。

@BensonLaur
Copy link
Member

BensonLaur commented Feb 26, 2020 •
edited

8b5141f 的修复似乎没找到关键点，等会我做个提交。

哦噢，好像是的，这个还被封装起来了

https://github.com/Beslyric-for-X/Beslyric-for-X/blob/8b5141f5ba94899ea2e6ae3fb235f0459abcf671/Entities/LyricMaker.cpp#L243-L252

匆匆忙忙改，看来还是得单独安排出些时间谨慎一点好

@pzhlkj6612
Copy link
Member

对，就是减去insertOffsetTime把时间弄错了。

@pzhlkj6612 pzhlkj6612 mentioned this issue Feb 26, 2020
Merged
@BensonLaur BensonLaur mentioned this issue Feb 29, 2020
Closed
@pzhlkj6612 pzhlkj6612 added this to the Next Release milestone Feb 29, 2020
pzhlkj6612 pushed a commit that referenced this issue Aug 13, 2020
@BensonLaur @pzhlkj6612
修复首句歌词时间戳标记异常问题
2cbaca2 
相关 issue #65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v3.1.2
3 participants
@BensonLaur @ish-kafel @pzhlkj6612