Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

发布版本 v3.1.2 #78

Closed
BensonLaur opened this issue Feb 29, 2020 · 2 comments · Fixed by #79
Closed

发布版本 v3.1.2 #78

BensonLaur opened this issue Feb 29, 2020 · 2 comments · Fixed by #79
Labels
_Release It's a release.
Milestone
v3.1.2

Comments

@BensonLaur
Copy link
Member

BensonLaur commented Feb 29, 2020 •
edited
Loading

@BensonLaur BensonLaur added this to the Next Release milestone Feb 29, 2020
@BensonLaur BensonLaur changed the title 发布版本 v3.1.3 发布版本 v3.1.2 Feb 29, 2020
@BensonLaur
Copy link
Member Author

related issue : BesLyric-for-X/BesLyric-for-Windows-Setup#3

@pzhlkj6612 pzhlkj6612 pinned this issue Feb 29, 2020
@pzhlkj6612 pzhlkj6612 added the _Release It's a release. label Feb 29, 2020
BensonLaur added a commit to BensonLaur/Beslyric-for-X that referenced this issue Feb 29, 2020
@BensonLaur
release version 3.1.2
c5daaf1 
close BesLyric-for-X#78
1、更新设置页面显示的版本信息
2、更新 exe 的版本信息
3、更新版本更新信息
@BensonLaur BensonLaur mentioned this issue Feb 29, 2020
Merged
@BensonLaur BensonLaur modified the milestone: Next Release Mar 1, 2020
BensonLaur added a commit to BensonLaur/Beslyric-for-X that referenced this issue Mar 1, 2020
@BensonLaur
pdate version.txt
b90379f 
fixes BesLyric-for-X#78
@BensonLaur
Copy link
Member Author

BensonLaur commented Mar 1, 2020 •
edited
Loading

合并后的代码 #79
https://github.com/Beslyric-for-X/Beslyric-for-X/blob/688f636ba5995cd36e2e9233a4c9a23df18ea5fe/Define/Static.h#L11
才会更新 【设置页面显示的版本信息】
https://github.com/Beslyric-for-X/Beslyric-for-X/blob/2ca419027982180ee1e6a7464a3c2ba86eda4538/MiddleWidgets/SettingWidget/SuUpgrade.cpp#L53
以及正确检测版本更新
https://github.com/Beslyric-for-X/Beslyric-for-X/blob/2488f3089ac61eb0ca4c1242fd003f3626feac77/Entities/ThreadCheckUpdate.h#L183-L185

@BensonLaur BensonLaur reopened this Mar 1, 2020
@pzhlkj6612 pzhlkj6612 unpinned this issue May 27, 2020
pzhlkj6612 pushed a commit that referenced this issue Aug 13, 2020
@BensonLaur @pzhlkj6612
release version 3.1.2
7024784 
close #78
1、更新设置页面显示的版本信息
2、更新 exe 的版本信息
3、更新版本更新信息
pzhlkj6612 pushed a commit that referenced this issue Aug 13, 2020
@BensonLaur @pzhlkj6612
pdate version.txt
3bcb968 
fixes #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
_Release It's a release.
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging a pull request may close this issue.

release version 3.1.2 BensonLaur/Beslyric-for-X
2 participants
@BensonLaur @pzhlkj6612