Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

退出前结束 ThreadLogin 和 ThreadCheckUpdate 线程 #30

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

pzhlkj6612
Copy link
Member

避免 qthread destroyed while thread is still running.

避免 qthread destroyed while thread is still running.
@BensonLaur BensonLaur merged commit 0dee64a into BesLyric-for-X:master Oct 8, 2019
@pzhlkj6612
Copy link
Member Author

pzhlkj6612 commented Dec 5, 2019

https://github.com/Beslyric-for-X/Beslyric-for-X/blob/0dee64a8834f1ba294b12f99fee97acc438ee500/StackFrame.cpp#L41-L44

由以下资料和现有代码逻辑得出,我写的这两个QThread::exit(int)方法在这里是没用的:

之后试试QEventLoop,看看这东西究竟怎么用;或者干脆就在QThread::wait()之前做一些处理(例如结束网络通信),真正实现线程的“立即结束”。

@pzhlkj6612 pzhlkj6612 deleted the quit_thread branch December 10, 2019 12:42
@pzhlkj6612 pzhlkj6612 added the bug Something isn't working label Feb 23, 2020
@pzhlkj6612 pzhlkj6612 removed the bug Something isn't working label Feb 23, 2020
@pzhlkj6612 pzhlkj6612 added this to the Next Release milestone Feb 24, 2020
@BensonLaur BensonLaur mentioned this pull request Feb 29, 2020
@pzhlkj6612 pzhlkj6612 changed the title 退出前结束线程 退出前结束 ThreadLogin 和 ThreadCheckUpdate 线程 Feb 29, 2020
@pzhlkj6612 pzhlkj6612 added the bug Something isn't working label Feb 29, 2020
@pzhlkj6612 pzhlkj6612 added the invalid This doesn't seem right label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants