Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

移除对于 SDL_INIT_TIMER 和 SDL_INIT_VIDEO 的初始化 #42

Conversation

pzhlkj6612
Copy link
Member

@pzhlkj6612 pzhlkj6612 commented Jan 6, 2020

相比于之前的写法,现在从点击音乐到音乐开始播放的延迟缩短了许多。

不同平台的表现:

  • Ubuntu 18.04 下现象明显;
  • Windows 10 1903 下没有明显改变;
  • macOS 10.14 下没有明显改变。

注:之后的 PR 中,若无特别说明,所使用的 FFmpeg 版本均与 beslyric-lib 一致(例如现在为 4.0.1 )。

It seems that the responding speed of the audio playing has been improved.
@pzhlkj6612 pzhlkj6612 force-pushed the remove_useless_initialization_of_SDL_subsystem branch from 2bebefa to ff7ef5d Compare January 7, 2020 11:07
@BensonLaur BensonLaur merged commit ff7ef5d into BesLyric-for-X:master Jan 18, 2020
@pzhlkj6612 pzhlkj6612 deleted the remove_useless_initialization_of_SDL_subsystem branch January 21, 2020 14:28
@pzhlkj6612 pzhlkj6612 changed the title Remove SDL_INIT_TIMER and SDL_INIT_VIDEO from SDL_Init() 移除对于 SDL_INIT_TIMER 和 SDL_INIT_VIDEO 的初始化 Feb 23, 2020
@pzhlkj6612 pzhlkj6612 added the _Refactor the player 整个播放逻辑需要重做。 label Feb 23, 2020
@pzhlkj6612 pzhlkj6612 added this to the Next Release milestone Feb 24, 2020
@BensonLaur BensonLaur mentioned this pull request Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_Refactor the player 整个播放逻辑需要重做。
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants