Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

避免对未成功获取(未初始化)的 AVPacket 进行释放 #52

Merged

Conversation

pzhlkj6612
Copy link
Member

Fixed #51
Patch for 0175326


本 PR 修复的问题在 Windows 平台上似乎是不存在的:

操作系统 编译器 FFmpeg 是否复现 #51
Windows 10 Microsoft (R) C/C++ Optimizing Compiler Version 19.00.24234.1 for x86 4.0.1/4.2.2 X
Windows 7 Microsoft (R) C/C++ Optimizing Compiler Version 19.24.28314 for x86 4.0.1/4.2.2 X
Ubuntu 18.04 gcc version 7.4.0 (Ubuntu 7.4.0-1ubuntu1~18.04.1) 4.2.2 O
macOS 10.14 Apple LLVM version 10.0.0 (clang-1000.10.44.4) 4.2.2 O

Patch for 0175326

`av_packet_unref()` the uninitialized AVPacket will crash the program on macOS and Ubuntu.
@pzhlkj6612 pzhlkj6612 force-pushed the Flow_wrong_in_audio_decode_frame branch from 81345a4 to df17e48 Compare January 29, 2020 09:46
@BensonLaur BensonLaur merged commit d399b0d into BesLyric-for-X:master Feb 19, 2020
@pzhlkj6612 pzhlkj6612 deleted the Flow_wrong_in_audio_decode_frame branch February 19, 2020 15:49
@pzhlkj6612 pzhlkj6612 added this to the Next Release milestone Feb 24, 2020
@pzhlkj6612 pzhlkj6612 added the _Refactor the player 整个播放逻辑需要重做。 label Feb 24, 2020
@BensonLaur BensonLaur mentioned this pull request Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_Refactor the player 整个播放逻辑需要重做。
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS 10.14 Ubuntu 18.04 开始播放时 AudioQueue thread 崩溃
2 participants