Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

注释对 AVPacket 的无用测试以避免段错误 #70

Merged
merged 1 commit into from
Feb 27, 2020
Merged

注释对 AVPacket 的无用测试以避免段错误 #70

merged 1 commit into from
Feb 27, 2020

Conversation

pzhlkj6612
Copy link
Member

Fixed #37

原因：

  • 在 macOS 10.14+ 进行 seek 或重新播放时，pkt1为null；
  • 这个if语句没有实际作用。

@pzhlkj6612
Avoid segfault by commenting useless test
14559c5 
on macOS 10.14+, when doing seeking or re-playing, `pkt1` would be null.
@pzhlkj6612 pzhlkj6612 added this to the Next Release milestone Feb 27, 2020
@pzhlkj6612 pzhlkj6612 merged commit de84d32 into BesLyric-for-X:master Feb 27, 2020
@pzhlkj6612 pzhlkj6612 deleted the null_packet_crashes_macos branch February 27, 2020 07:40
@BensonLaur BensonLaur mentioned this pull request Feb 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.

macOS 10.14+ seek 或重新播放时 PlayerThread 崩溃
1 participant
@pzhlkj6612