Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove electron from dependencies #328

Open
TimoZikeli opened this issue Oct 13, 2022 · 0 comments · May be fixed by #329
Open

Remove electron from dependencies #328

TimoZikeli opened this issue Oct 13, 2022 · 0 comments · May be fixed by #329
Labels
bug Something isn't working

Comments

@TimoZikeli
Copy link

TimoZikeli commented Oct 13, 2022 •
edited

Since electron is listed as dependency, it is packaged when the electron app is build which leads to the electron binary being included again in the app!

image

Fix: list in devDependencies instead
@TimoZikeli TimoZikeli added the bug Something isn't working label Oct 13, 2022
TimoZikeli added a commit to TimoZikeli/vuex-electron-store that referenced this issue Oct 13, 2022
@TimoZikeli
Move electron to devDependencies
9a6e235 
Fixes BetaHuhn#328
@TimoZikeli TimoZikeli linked a pull request Oct 13, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move electron to devDependencies TimoZikeli/vuex-electron-store
1 participant
@TimoZikeli