Split character widths into their own line to have a cleaner diff #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Characters with default width will just use the DEFAULT_CHAR_WIDTH when querying from the map anyways and this makes the special widths easier to see.
Wolf2323
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes wrong widths of special characters for calculating the display string width for the default Minecraft font. These widths were validated by me now again and also match what I have been using in TravelPortals for a while now. (The widths in TravelPortals are all one less than the ones in BetonQuests' class as that calculator manually adds the 1px width between chars in the calculation)
I also took the liberty of improving the way the LocalChatPaginator is formatted.
DEFAULT_CHAR_WIDTHand they just make the list of widths a lot harder to readRelated Issues
Closes #XXXXCouldn't find one that looks exactly like this, maybe #2005 could be somewhat related although I didn't really understand what the issue exactly is in there.Requirements
Reviewer's checklist
Did the contributor...
Check if the build pipeline succeeded for this PR!